Showing 970 of 970 total issues
Function map
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
map : function (mappedMin, mappedMax) {
var input = this._array;
var output = this._array;
var min = input[0];
Function _parseRanges
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
_parseRanges : function (index) {
var rangesStr = index.split(/\s*,\s*/);
// Parse range of each axis
var ranges = [];
Function display
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
display: function() {
var
title = settings.name + ':',
totalTime = 0
;
Function display
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
display: function() {
var
title = settings.name + ':',
totalTime = 0
;
Function display
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
display: function() {
var
title = settings.name + ':',
totalTime = 0
;
Function display
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
display: function() {
var
title = settings.name + ':',
totalTime = 0
;
Function legacyPushPage
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
legacyPushPage: function(callback) {
var
distance = $module.width(),
direction = module.get.direction(),
properties = {}
Function display
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
display: function() {
var
title = settings.name + ':',
totalTime = 0
;
Function display
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
display: function() {
var
title = settings.name + ':',
totalTime = 0
;
Function display
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
display: function() {
var
title = settings.name + ':',
totalTime = 0
;
Function display
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
display: function() {
var
title = settings.name + ':',
totalTime = 0
;
Function display
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
display: function() {
var
title = settings.name + ':',
totalTime = 0
;
Function display
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
display: function() {
var
title = settings.name + ':',
totalTime = 0
;
Function text
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
text: function() {
if( module.is.textEnabled() ) {
if(module.is.disabled() ) {
module.verbose('Changing text to disabled text', text.hover);
module.update.text(text.disabled);
Function display
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
display: function() {
var
title = settings.name + ':',
totalTime = 0
;
Function display
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
display: function() {
var
title = settings.name + ':',
totalTime = 0
;
Function display
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
display: function() {
var
title = settings.name + ':',
totalTime = 0
;
Function pack
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
shape, series, seriesIndex, data, dataIndex, name, special, special2
Identical blocks of code found in 2 locations. Consider refactoring. Open
$result
.removeClass(className.active)
.eq(newIndex)
.addClass(className.active)
.closest($category)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 55.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
$scope.rBarrios = ubicaciones
.filter(function(obj){return !!obj[0] && !!obj[1] && !!obj[2]})
.map(function(obj){return obtenerUbicacion(obj, true, true);});
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 55.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76