Sign upLogin

neopoly/bound

View on GitHub
Star

Showing 6 of 6 total issues

File bound.rb has 271 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "bound/version"
require "bound/caller"
require "bound/errors"

class Bound
Severity: Minor
Found in lib/bound.rb - About 2 hrs to fix

    Method define_nested_delegate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.define_nested_delegate(attr, nested_class)
      define_delegate attr, 'get_'
      code = <<-EOR
        class << self
          def get_#{attr}_class
    Severity: Minor
    Found in lib/bound.rb - About 1 hr to fix

      Method assert_correctness has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      def assert_correctness(bound)
  raise('foo is wrong') unless bound.foo == 'NOPE'
  raise('bar size is wrong') unless bound.bar.size == 2
  raise('bar[0] is wrong') unless bound.bar[0].abc == 'TRUE'
  raise('bar[1] is wrong') unless bound.bar[1].abc == 'FALSE'
      Severity: Minor
      Found in benchmark.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method ensure_array! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def ensure_array!(attribute)
      message = "Expected %s to be an array"
      if overwritten?(attribute)
        unless val = overwritten(attribute).kind_of?(Array)
          raise(ArgumentError, message % val.inspect)
      Severity: Minor
      Found in lib/bound.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              code += <<-EOR
          def #{attr}
            return @#{attr} if defined? @#{attr}
            return [] unless val = get_#{attr}
            @#{attr} ||= val.map{|t| self.class.get_#{attr}_class.new t}
      Severity: Minor
      Found in lib/bound.rb and 1 other location - About 15 mins to fix
      lib/bound.rb on lines 282..290

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              code += <<-EOR
          def #{attr}
            return @#{attr} if defined? @#{attr}
            return nil unless val = get_#{attr}
            @#{attr} ||= self.class.get_#{attr}_class.new(val)
      Severity: Minor
      Found in lib/bound.rb and 1 other location - About 15 mins to fix
      lib/bound.rb on lines 273..281

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language