Sign upLogin

nephila/django-filer-celery

View on GitHub
Star

Showing 9 of 9 total issues

Function ajax_upload has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

def ajax_upload(request, folder_id=None):
    """
    Receives an upload from the uploader. Receives only one file at a time.
    """
    mimetype = 'application/json' if request.is_ajax() else 'text/html'
Severity: Minor
Found in filer_celery/views.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function load_aliases has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def load_aliases():
    """
    Load ThumbnailOption as easy-thumbnails aliases
    """
    def _load_aliases():
Severity: Minor
Found in filer_celery/utils.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _generate_thumbnails has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def _generate_thumbnails(self, required_thumbnails):
    _thumbnails = {}
    for name, opts in iteritems(required_thumbnails):
        try:
            opts.update({'subject_location': self.subject_location})
Severity: Minor
Found in filer_celery/models.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _warn_node has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def _warn_node(self, msg, node, *args, **kwargs):
Severity: Minor
Found in docs/conf.py - About 35 mins to fix

    Function render_tag has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def render_tag(self, context, source, options, async, varname):
    Severity: Minor
    Found in filer_celery/templatetags/filer_celery.py - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          except UploadException as e:  # pragma: no cover
        return HttpResponse(json.dumps({'error': str(e)}), status=500, **response_params)
      Severity: Minor
      Found in filer_celery/views.py and 1 other location - About 35 mins to fix
      filer_celery/views.py on lines 118..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          except Exception as e:  # pragma: no cover
        return HttpResponse(json.dumps({'error': str(e)}), status=500, **response_params)
      Severity: Minor
      Found in filer_celery/views.py and 1 other location - About 35 mins to fix
      filer_celery/views.py on lines 116..117

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

              return HttpResponse(json.dumps({'error': str(e)}), status=500, **response_params)
      Severity: Major
      Found in filer_celery/views.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return HttpResponse(json.dumps({'error': str(e)}), status=500, **response_params)
        Severity: Major
        Found in filer_celery/views.py - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language