nephila/djangocms-installer

View on GitHub
djangocms_installer/config/__init__.py

Summary

Maintainability
F
4 days
Test Coverage

Function parse has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
Open

def parse(args):
    """
    Define the available arguments
    """
    from tzlocal import get_localzone
Severity: Minor
Found in djangocms_installer/config/__init__.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File __init__.py has 479 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import argparse
import locale
import os.path
import sys
import warnings
Severity: Minor
Found in djangocms_installer/config/__init__.py - About 7 hrs to fix

    Function _manage_args has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
    Open

    def _manage_args(parser, args):
        """
        Checks and validate provided input
        """
        for item in data.CONFIGURABLE_OPTIONS:
    Severity: Minor
    Found in djangocms_installer/config/__init__.py - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parse has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def parse(args):
        """
        Define the available arguments
        """
        from tzlocal import get_localzone
    Severity: Major
    Found in djangocms_installer/config/__init__.py - About 2 hrs to fix

      Avoid deeply nested control flow statements.
      Open

                          if new_val != "no" and not os.path.isdir(new_val):
                              sys.stdout.write("Given directory does not exists, retry\n")
                              new_val = False
                      if new_val and action.dest == "db":
      Severity: Major
      Found in djangocms_installer/config/__init__.py - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if args.cms_version in ("rc", "develop"):
                        requirements.extend(data.REQUIREMENTS["plugins-master"])
                    elif LooseVersion(cms_version) >= LooseVersion("3.7"):
                        requirements.extend(data.REQUIREMENTS["plugins-3.7"])
        Severity: Major
        Found in djangocms_installer/config/__init__.py and 1 other location - About 3 hrs to fix
        djangocms_installer/config/__init__.py on lines 430..433

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if args.cms_version in ("rc", "develop"):
                    requirements.extend(data.REQUIREMENTS["cms-master"])
                elif LooseVersion(cms_version) >= LooseVersion("3.7"):
                    requirements.extend(data.REQUIREMENTS["cms-3.7"])
        Severity: Major
        Found in djangocms_installer/config/__init__.py and 1 other location - About 3 hrs to fix
        djangocms_installer/config/__init__.py on lines 438..441

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if cms_version is None:  # pragma: no cover
                sys.stderr.write(
                    "Please provide a django CMS supported version: {}. Only Major.Minor "
                    "version selector is accepted\n".format(", ".join(data.DJANGOCMS_SUPPORTED))
                )
        Severity: Major
        Found in djangocms_installer/config/__init__.py and 1 other location - About 1 hr to fix
        djangocms_installer/config/__init__.py on lines 392..397

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if django_version is None:  # pragma: no cover
                sys.stderr.write(
                    "Please provide a Django supported version: {}. Only Major.Minor "
                    "version selector is accepted\n".format(", ".join(data.DJANGO_SUPPORTED))
                )
        Severity: Major
        Found in djangocms_installer/config/__init__.py and 1 other location - About 1 hr to fix
        djangocms_installer/config/__init__.py on lines 398..403

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status