Sign upLogin

nephila/djangocms-installer

View on GitHub
Star
djangocms_installer/django/__init__.py

Summary

Maintainability
D
2 days
Test Coverage

File __init__.py has 341 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import glob
import os
import re
import shutil
import subprocess
Severity: Minor
Found in djangocms_installer/django/__init__.py - About 4 hrs to fix

    Function _build_settings has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    def _build_settings(config_data):
    """
    Build the django CMS settings dictionary

    :param config_data: configuration data
    Severity: Minor
    Found in djangocms_installer/django/__init__.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function copy_files has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    def copy_files(config_data):
    """
    It's a little rude actually: it just overwrites the django-generated urls.py
    with a custom version and put other files in the project directory.
    Severity: Minor
    Found in djangocms_installer/django/__init__.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setup_database has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def setup_database(config_data):
    """
    Run the migrate command to create the database schema

    :param config_data: configuration data
    Severity: Minor
    Found in djangocms_installer/django/__init__.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _build_settings has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def _build_settings(config_data):
    """
    Build the django CMS settings dictionary

    :param config_data: configuration data
    Severity: Minor
    Found in djangocms_installer/django/__init__.py - About 1 hr to fix

      Function patch_settings has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      def patch_settings(config_data):
    """
    Modify the settings file created by Django injecting the django CMS
    configuration
      Severity: Minor
      Found in djangocms_installer/django/__init__.py - About 1 hr to fix

        Function patch_settings has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        def patch_settings(config_data):
    """
    Modify the settings file created by Django injecting the django CMS
    configuration
        Severity: Minor
        Found in djangocms_installer/django/__init__.py - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function create_project has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        def create_project(config_data):
    """
    Call django-admin to create the project structure

    :param config_data: configuration data
        Severity: Minor
        Found in djangocms_installer/django/__init__.py - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                            if config_name == "code":
                        cms_text.append("{}'{}': '{}',".format(spacer * 3, config_name, config_value))  # NOQA
                    elif config_name == "name":
                        cms_text.append("{}'{}': gettext('{}'),".format(spacer * 3, config_name, config_value))  # NOQA
                    else:
        Severity: Major
        Found in djangocms_installer/django/__init__.py - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if config_data.filer:
        text.append(
            "THUMBNAIL_PROCESSORS = (\n{}{}\n)".format(
                spacer,
                (",\n" + spacer).join(["'{}'".format(var) for var in settings_data.THUMBNAIL_PROCESSORS]),
          Severity: Major
          Found in djangocms_installer/django/__init__.py and 1 other location - About 1 hr to fix
          djangocms_installer/django/__init__.py on lines 231..234

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              text.append(
        "MIDDLEWARE = [\n{}{}\n]".format(
            spacer,
            (",\n" + spacer).join(["'{}'".format(var) for var in settings_data.MIDDLEWARE_CLASSES]),
          Severity: Major
          Found in djangocms_installer/django/__init__.py and 1 other location - About 1 hr to fix
          djangocms_installer/django/__init__.py on lines 325..329

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  for filename in glob.glob(os.path.join(share_path, "starting_page.*")):
            if os.path.isfile(filename):
                shutil.copy(filename, os.path.join(config_data.project_path, ".."))
          Severity: Minor
          Found in djangocms_installer/django/__init__.py and 1 other location - About 35 mins to fix
          djangocms_installer/django/__init__.py on lines 93..94

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if os.path.isfile(script_path):
            shutil.copy(script_path, os.path.join(config_data.project_path, ".."))
          Severity: Minor
          Found in djangocms_installer/django/__init__.py and 1 other location - About 35 mins to fix
          djangocms_installer/django/__init__.py on lines 97..99

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status