nertwork/frr-cookbook

View on GitHub

Showing 25 of 25 total issues

Do not use spaces inside percent literal delimiters.
Open

if %w( debian ubuntu cumulus ).include? node['platform']
Severity: Minor
Found in recipes/install.rb by rubocop

Checks for unnecessary additional spaces inside the delimiters of %i/%w/%x literals.

Example:

# good
%i(foo bar baz)

# bad
%w( foo bar baz )

# bad
%x(  ls -l )

Use %i or %I for an array of symbols.
Open

task :integration, [:regexp, :action] =>
Severity: Minor
Found in Rakefile by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem kitchen-vagrant should appear before test-kitchen.
Open

  gem 'kitchen-vagrant'
Severity: Minor
Found in Gemfile by rubocop

Gems should be alphabetically sorted within groups.

Example:

# bad
gem 'rubocop'
gem 'rspec'

# good
gem 'rspec'
gem 'rubocop'

# good
gem 'rubocop'

gem 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'

TODO found
Open

# TODO: Change to FRR
Severity: Minor
Found in attributes/default.rb by fixme

TODO found
Open

# daemons defaults TODO: Change to FRR
Severity: Minor
Found in attributes/default.rb by fixme
Severity
Category
Status
Source
Language