nesquena/gitdocs

View on GitHub

Showing 676 of 676 total issues

Add an empty line after magic comments.
Open

module Gitdocs
Severity: Minor
Found in lib/gitdocs/repository/committer.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Element (div.share) is overqualified, just use .share without element name.
Open

div.share {
Severity: Minor
Found in lib/gitdocs/public/css/app.css by csslint

Outlines should only be modified using :focus.
Open

a:hover,a:active{outline:0;}

The property -moz-appearance is compatible with -webkit-appearance and should be included as well.
Open

input[type="search"]::-webkit-search-decoration{-webkit-appearance:none;}

Heading (h6) has already been defined.
Open

h3,h4,h5,h6{line-height:36px;}

Heading (h4) has already been defined.
Open

h3,h4,h5,h6{line-height:36px;}

Property with star prefix found.
Open

fieldset{margin-bottom:18px;padding-top:18px;}fieldset legend{display:block;padding-left:150px;font-size:19.5px;line-height:1;color:#404040;*padding:0 0 5px 145px;*line-height:1.5;}

Rule doesn't have all its properties in alphabetical order.
Open

input[type=file]{background-color:#ffffff;padding:initial;border:initial;line-height:initial;-webkit-box-shadow:none;-moz-box-shadow:none;box-shadow:none;}

Adjoining classes: form .clearfix.error input
Open

form .clearfix.error input,form .clearfix.error textarea{color:#b94a48;border-color:#ee5f5b;}form .clearfix.error input:focus,form .clearfix.error textarea:focus{border-color:#e9322d;-webkit-box-shadow:0 0 6px #f8b9b7;-moz-box-shadow:0 0 6px #f8b9b7;box-shadow:0 0 6px #f8b9b7;}

Rule doesn't have all its properties in alphabetical order.
Open

input.span6,textarea.span6{display:inline-block;float:none;width:330px;margin-left:0;}

Rule doesn't have all its properties in alphabetical order.
Open

input.span13,textarea.span13{display:inline-block;float:none;width:750px;margin-left:0;}

Rule doesn't have all its properties in alphabetical order.
Open

.actions{background:#f5f5f5;margin-top:18px;margin-bottom:18px;padding:17px 20px 18px 150px;border-top:1px solid #ddd;-webkit-border-radius:0 0 3px 3px;-moz-border-radius:0 0 3px 3px;border-radius:0 0 3px 3px;}.actions .secondary-action{float:right;}.actions .secondary-action a{line-height:30px;}.actions .secondary-action a:hover{text-decoration:underline;}

Using height with padding can sometimes make elements larger than you expect.
Open

.input-prepend .add-on,.input-append .add-on{position:relative;background:#f5f5f5;border:1px solid #ccc;z-index:2;float:left;display:block;width:auto;min-width:16px;height:18px;padding:4px 4px 4px 5px;margin-right:-1px;font-weight:normal;line-height:18px;color:#bfbfbf;text-align:center;text-shadow:0 1px 0 #ffffff;-webkit-border-radius:3px 0 0 3px;-moz-border-radius:3px 0 0 3px;border-radius:3px 0 0 3px;}

Expected (<filter-function-list> | none) but found 'alpha(opacity=60)'.</filter-function-list>
Open

table .headerSortUp:after{border-bottom:none;border-left:4px solid transparent;border-right:4px solid transparent;border-top:4px solid #000;visibility:visible;-webkit-box-shadow:none;-moz-box-shadow:none;box-shadow:none;filter:alpha(opacity=60);-khtml-opacity:0.6;-moz-opacity:0.6;opacity:0.6;}

Adjoining classes: table .headerSortUp.yellow
Open

table .headerSortUp.yellow,table .headerSortDown.yellow{background-color:#fff6d9;}

Unnecessary utf-8 encoding comment.
Open

# -*- encoding : utf-8 -*-
Severity: Minor
Found in lib/gitdocs/repository.rb by rubocop

%w-literals should be delimited by [ and ].
Open

              urls: %w(/css /js /img /doc),
Severity: Minor
Found in lib/gitdocs/celluloid_facade.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Avoid rescuing without specifying an error class.
Open

    rescue # rubocop:disable Lint/HandleExceptions
Severity: Minor
Found in lib/gitdocs/notifier.rb by rubocop

This cop checks for rescuing StandardError. There are two supported styles implicit and explicit. This cop will not register an offense if any error other than StandardError is specified.

Example: EnforcedStyle: implicit

# `implicit` will enforce using `rescue` instead of
# `rescue StandardError`.

# bad
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

Example: EnforcedStyle: explicit (default)

# `explicit` will enforce using `rescue StandardError`
# instead of `rescue`.

# bad
begin
  foo
rescue
  bar
end

# good
begin
  foo
rescue StandardError
  bar
end

# good
begin
  foo
rescue OtherError
  bar
end

# good
begin
  foo
rescue StandardError, SecurityError
  bar
end

Don't use IDs in selectors.
Open

#editor {
Severity: Minor
Found in lib/gitdocs/public/css/app.css by csslint

Heading (h6) has already been defined.
Open

h6{font-size:13px;color:#bfbfbf;text-transform:uppercase;}
Severity
Category
Status
Source
Language