Sign upLogin

nesquena/gitdocs

View on GitHub
Star

Showing 676 of 676 total issues

Function humanize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  humanize : function(str, shortened) {
    var parts = str.split('T')[0].split('-');
    var humDate = new Date();

    humDate.setFullYear(Number(parts[0]));
Severity: Minor
Found in lib/gitdocs/public/js/util.js - About 1 hr to fix

    Block has too many lines. [37/25]
    Open

        describe 'with remote' do
      before { clone_remote }

      describe 'and times out' do
        before do
    Severity: Minor
    Found in test/unit/repository_test.rb by rubocop

    This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

    Method after_teardown has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def after_teardown
    restore_env
    processes.clear

    if File.exist?(PID_FILE)
    Severity: Minor
    Found in test/integration/test_helper.rb - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          describe '.warn' do
      subject { Gitdocs::Notifier.warn('title', 'message', show_notification) }

      before { Gitdocs.expects(:log_warn).with('title: message') }
      Severity: Major
      Found in test/unit/notifier_test.rb and 1 other location - About 1 hr to fix
      test/unit/notifier_test.rb on lines 45..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          describe '.error' do
      subject { Gitdocs::Notifier.error('title', 'message', show_notification) }

      before { Gitdocs.expects(:log_error).with('title: message') }
      Severity: Major
      Found in test/unit/notifier_test.rb and 1 other location - About 1 hr to fix
      test/unit/notifier_test.rb on lines 27..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method after_teardown has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def after_teardown
    restore_env
    processes.clear

    if File.exist?(PID_FILE)
      Severity: Minor
      Found in test/integration/test_helper.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function humanizeBytes has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        humanizeBytes : function(filesize) {
    if (filesize === null || filesize <= 0 || filesize === "") { return "&mdash;"; }
    if (filesize >= 1073741824) {
         filesize = Utils.number_format(filesize / 1073741824, 2, '.', '') + ' Gb';
    } else {
      Severity: Minor
      Found in lib/gitdocs/public/js/util.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Block has too many lines. [35/25]
      Open

          describe 'remote exists with commits' do
      before { clone_remote_with_commit }

      describe 'and no local commits' do
        it { subject.must_equal :nothing }
      Severity: Minor
      Found in test/unit/repository_test.rb by rubocop

      This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

      Method start has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def start(host, port)
      Gitdocs.log_info("Starting Gitdocs v#{VERSION}...")
      Gitdocs.log_info(
        "Using configuration root: '#{Initializer.root_dirname}'"
      )
      Severity: Minor
      Found in lib/gitdocs/manager.rb - About 1 hr to fix

        Block has too many lines. [34/25]
        Open

          describe 'get /search' do
    before do
      Gitdocs::Search.stubs(:search).with('term').returns(results)

      get '/search', q: 'term'
        Severity: Minor
        Found in test/unit/browser_app_test.rb by rubocop

        This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

        Block has too many lines. [34/25]
        Open

            describe 'post /:id' do
      before { repository_path.stubs(relative_path: 'path1/path2/new') }

      describe 'upload' do
        before do
        Severity: Minor
        Found in test/unit/browser_app_test.rb by rubocop

        This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

        Function distance_of_time_in_words has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          distance_of_time_in_words: function(to, from) {
      var distance_in_seconds = ((to - from) / 1000);
      var distance_in_minutes = Math.floor(distance_in_seconds / 60);

      if (distance_in_minutes <= 0) { return 'less than a minute ago'; }
        Severity: Minor
        Found in lib/gitdocs/public/js/util.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Block has too many lines. [32/25]
        Open

          describe '#grep' do
    subject { repository.grep('foo') { |file, context| @grep_result << "#{file} #{context}" } }

    before { @grep_result = [] }
        Severity: Minor
        Found in test/unit/repository_test.rb by rubocop

        This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              describe 'side effects' do
        before { subject }
        it { GitInspector.commit_count(:local).must_equal 2 }
        it { GitInspector.file_count(:local).must_equal 3 }
        it { GitInspector.file_content(:local, 'file1 (f6ea049 original)').must_equal 'foobar' }
        Severity: Minor
        Found in test/unit/repository_test.rb and 1 other location - About 55 mins to fix
        test/unit/repository_test.rb on lines 401..407

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              describe 'side effects' do
        before { subject }
        it { GitInspector.commit_count(:local).must_equal 2 }
        it { GitInspector.file_count(:local).must_equal 3 }
        it { GitInspector.file_content(:local, 'file1 (f6ea049 original)').must_equal 'foobar' }
        Severity: Minor
        Found in test/unit/repository_test.rb and 1 other location - About 55 mins to fix
        test/unit/repository_test.rb on lines 422..428

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Block has too many lines. [31/25]
        Open

              describe 'revisions' do
        before do
          repository_path.stubs(revisions: revisions)

          get '/1234/path1/path2', mode: 'revisions'
        Severity: Minor
        Found in test/unit/browser_app_test.rb by rubocop

        This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

        Block has too many lines. [31/25]
        Open

          describe 'initialize' do
    subject { repository }

    describe 'with a missing path' do
      let(:path_or_share) { expand_path(:missing) }
        Severity: Minor
        Found in test/unit/repository_test.rb by rubocop

        This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

        Block has too many lines. [31/25]
        Open

        describe 'Manage which shares are being watched' do
  it 'should update a share through the UI' do
    gitdocs_add('local')
    gitdocs_start
    visit_and_click_link('Settings')
        Severity: Minor
        Found in test/integration/web/share_management_test.rb by rubocop

        This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

        Block has too many lines. [31/25]
        Open

            no_tasks do
      # @return [Dante::Runner]
      def runner
        Dante::Runner.new(
          'gitdocs',
        Severity: Minor
        Found in lib/gitdocs/cli.rb by rubocop

        This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

        Function number_format has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          number_format : function( number, decimals, dec_point, thousands_sep ) {
      var n = number, c = isNaN(decimals = Math.abs(decimals)) ? 2 : decimals;
      var d = dec_point === undefined ? "," : dec_point;
      var t = thousands_sep === undefined ? "." : thousands_sep, s = n < 0 ? "-" : "";
      var i = parseInt(n = Math.abs(+n || 0).toFixed(c), 10) + "", j = (j = i.length) > 3 ? j % 3 : 0;
        Severity: Minor
        Found in lib/gitdocs/public/js/util.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language