Sign upLogin

nesquena/gitdocs

View on GitHub
Star
test/unit/git_notifier_test.rb

Summary

Maintainability
A
30 mins
Test Coverage

Block has too many lines. [98/25]
Open

describe Gitdocs::GitNotifier do
  let(:git_notifier) { Gitdocs::GitNotifier.new(:root, :show_notifications) }

  describe '.for_merge' do
    subject { git_notifier.for_merge(result) }
Severity: Minor
Found in test/unit/git_notifier_test.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [44/25]
Open

  describe '.for_merge' do
    subject { git_notifier.for_merge(result) }

    describe 'with no changes' do
      before do
Severity: Minor
Found in test/unit/git_notifier_test.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [38/25]
Open

  describe '.for_push' do
    subject { git_notifier.for_push(result) }

    describe 'with no changes' do
      before do
Severity: Minor
Found in test/unit/git_notifier_test.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    describe 'with changes' do
      let(:result) { { 'Alice' => 1, 'Bob' => 3 } }
      before do
        Gitdocs::Notifier.expects(:info).with(
          'Pushed 4 changes', 'root has been pushed', :show_notifications
Severity: Minor
Found in test/unit/git_notifier_test.rb and 1 other location - About 15 mins to fix
test/unit/git_notifier_test.rb on lines 22..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    describe 'with changes' do
      let(:result) { { 'Alice' => 1, 'Bob' => 3 } }
      before do
        Gitdocs::Notifier.expects(:info).with(
          'Updated with 4 changes',
Severity: Minor
Found in test/unit/git_notifier_test.rb and 1 other location - About 15 mins to fix
test/unit/git_notifier_test.rb on lines 74..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Unnecessary utf-8 encoding comment.
Open

# -*- encoding : utf-8 -*-
Severity: Minor
Found in test/unit/git_notifier_test.rb by rubocop

Add an empty line after magic comments.
Open

require File.expand_path('../test_helper', __FILE__)
Severity: Minor
Found in test/unit/git_notifier_test.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

There are no issues that match your filters.

Category
Status