netdata/netdata

View on GitHub
src/collectors/python.d.plugin/python_modules/urllib3/poolmanager.py

Summary

Maintainability
C
7 hrs
Test Coverage

File poolmanager.py has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# SPDX-License-Identifier: MIT
from __future__ import absolute_import
import collections
import functools
import logging
Severity: Minor
Found in src/collectors/python.d.plugin/python_modules/urllib3/poolmanager.py - About 3 hrs to fix

    Function _merge_pool_kwargs has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def _merge_pool_kwargs(self, override):
            """
            Merge a dictionary of override values for self.connection_pool_kw.
    
            This does not modify self.connection_pool_kw and returns a new dict.

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function urlopen has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def urlopen(self, method, url, redirect=True, **kw):
            """
            Same as :meth:`urllib3.connectionpool.HTTPConnectionPool.urlopen`
            with custom cross-host redirect logic and only sends the request-uri
            portion of the ``url``.

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _default_key_normalizer has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def _default_key_normalizer(key_class, request_context):
        """
        Create a pool key out of a request context dictionary.
    
        According to RFC 3986, both the scheme and host are case-insensitive.
    Severity: Minor
    Found in src/collectors/python.d.plugin/python_modules/urllib3/poolmanager.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, proxy_url, num_pools=10, headers=None,
    Severity: Minor
    Found in src/collectors/python.d.plugin/python_modules/urllib3/poolmanager.py - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status