Sign upLogin

netdata/netdata

View on GitHub
Star
src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py

Summary

Maintainability
D
2 days
Test Coverage

File smartd_log.chart.py has 582 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
# Description: smart netdata python.d module
# Author: ilyam8, vorph1
# SPDX-License-Identifier: GPL-3.0-or-later
Severity: Major
Found in src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py - About 1 day to fix

    Function get_data has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_data(self):
        self.runs += 1

        if self.do_force_rescan or self.runs % DEF_RESCAN_INTERVAL == 0:
            self.cleanup()
    Severity: Minor
    Found in src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create_disk_from_file has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def create_disk_from_file(self, full_name, current_time):
        if not full_name.endswith(CSV):
            self.debug('skipping {0}: not a csv file'.format(full_name))
            return None
    Severity: Minor
    Found in src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add_disk_to_charts has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def add_disk_to_charts(self, disk):
        if len(self.charts) == 0 or disk.charted:
            return
        disk.charted = True
    Severity: Minor
    Found in src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

            return disk
    Severity: Major
    Found in src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return AtaNormalized(*value)
      Severity: Major
      Found in src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return None
        Severity: Major
        Found in src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return None
          Severity: Major
          Found in src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return AtaRaw(*value)
            Severity: Major
            Found in src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return None
              Severity: Major
              Found in src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return None
                Severity: Major
                Found in src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  class Ata3(BaseAtaSmartAttribute):
    def value(self):
        value = int(self.raw_value)
        # https://github.com/netdata/netdata/issues/5919
        #
                  Severity: Major
                  Found in src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py and 1 other location - About 1 hr to fix
                  src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py on lines 486..491

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 43.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  class Ata9(BaseAtaSmartAttribute):
    def value(self):
        value = int(self.raw_value)
        if value > 1e6:
            return value & 0xFFFF
                  Severity: Major
                  Found in src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py and 1 other location - About 1 hr to fix
                  src/collectors/python.d.plugin/smartd_log/smartd_log.chart.py on lines 472..483

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 43.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status