netdata/netdata

View on GitHub
src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go

Summary

Maintainability
F
3 days
Test Coverage

File charts.go has 790 lines of code (exceeds 500 allowed). Consider refactoring.
Open

// SPDX-License-Identifier: GPL-3.0-or-later

package elasticsearch

import (
Severity: Major
Found in src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        nodeThreadPoolQueuedChartTmpl = module.Chart{
            ID:       "node_%s_cluster_%s_thread_pool_queued",
            Title:    "Thread Pool Queued Threads Count",
            Units:    "threads",
            Fam:      "thread pool",
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 453..478

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 243.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        nodeThreadPoolRejectedChartTmpl = module.Chart{
            ID:       "node_%s_cluster_%s_thread_pool_rejected",
            Title:    "Thread Pool Rejected Threads Count",
            Units:    "threads",
            Fam:      "thread pool",
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 427..452

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 243.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        clusterNodesByRoleCountChartTmpl = module.Chart{
            ID:       "cluster_%s_nodes_by_role_count",
            Title:    "Cluster Nodes By Role Count",
            Units:    "nodes",
            Fam:      "cluster stats",
    src/go/collectors/go.d.plugin/modules/windows/charts.go on lines 3603..3624

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 198.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        nodeBreakersTripsChartTmpl = module.Chart{
            ID:       "node_%s_cluster_%s_breakers_trips",
            Title:    "Circuit Breaker Trips Count",
            Units:    "trips/s",
            Fam:      "circuit breakers",
    src/go/collectors/go.d.plugin/modules/mongodb/charts.go on lines 391..407

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 189.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (es *Elasticsearch) addClusterHealthCharts() {
        charts := clusterHealthChartsTmpl.Copy()
    
        for _, chart := range *charts {
            chart.ID = fmt.Sprintf(chart.ID, es.clusterName)
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 759..772

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 144.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (es *Elasticsearch) addClusterStatsCharts() {
        charts := clusterStatsChartsTmpl.Copy()
    
        for _, chart := range *charts {
            chart.ID = fmt.Sprintf(chart.ID, es.clusterName)
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 774..787

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 144.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        clusterShardsCountChartTmpl = module.Chart{
            ID:       "cluster_%s_shards_count",
            Title:    "Cluster Shards Count",
            Units:    "shards",
            Fam:      "cluster health",
    Severity: Major
    Found in src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go and 4 other locations - About 55 mins to fix
    src/go/collectors/go.d.plugin/modules/mongodb/charts.go on lines 374..389
    src/go/collectors/go.d.plugin/modules/mysql/charts.go on lines 776..791
    src/go/collectors/go.d.plugin/modules/nginxplus/charts.go on lines 453..468
    src/go/collectors/go.d.plugin/modules/nvme/charts.go on lines 120..135

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 126.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        nodeIndicesSearchOpsChartTmpl = module.Chart{
            ID:       "node_%s_cluster_%s_indices_search_operations",
            Title:    "Search Operations",
            Units:    "operations/s",
            Fam:      "indices search",
    Severity: Major
    Found in src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go and 7 other locations - About 35 mins to fix
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 171..183
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 400..412
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 413..425
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 666..678
    src/go/collectors/go.d.plugin/modules/mongodb/charts.go on lines 809..821
    src/go/collectors/go.d.plugin/modules/mysql/charts.go on lines 1067..1079
    src/go/collectors/go.d.plugin/modules/mysql/charts.go on lines 1105..1117

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        nodeJVMGCTimeChartTmpl = module.Chart{
            ID:       "node_%s_cluster_%s_jvm_gc_time",
            Title:    "JVM Time Spent On Garbage Collections",
            Units:    "milliseconds",
            Fam:      "jvm",
    Severity: Major
    Found in src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go and 7 other locations - About 35 mins to fix
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 145..157
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 171..183
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 400..412
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 666..678
    src/go/collectors/go.d.plugin/modules/mongodb/charts.go on lines 809..821
    src/go/collectors/go.d.plugin/modules/mysql/charts.go on lines 1067..1079
    src/go/collectors/go.d.plugin/modules/mysql/charts.go on lines 1105..1117

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        nodeJVMGCCountChartTmpl = module.Chart{
            ID:       "node_%s_cluster_%s_jvm_gc_count",
            Title:    "JVM Garbage Collections",
            Units:    "gc/s",
            Fam:      "jvm",
    Severity: Major
    Found in src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go and 7 other locations - About 35 mins to fix
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 145..157
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 171..183
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 413..425
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 666..678
    src/go/collectors/go.d.plugin/modules/mongodb/charts.go on lines 809..821
    src/go/collectors/go.d.plugin/modules/mysql/charts.go on lines 1067..1079
    src/go/collectors/go.d.plugin/modules/mysql/charts.go on lines 1105..1117

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        nodeIndicesSearchOpsTimeChartTmpl = module.Chart{
            ID:       "node_%s_cluster_%s_indices_search_operations_time",
            Title:    "Time Spent On Search Operations",
            Units:    "milliseconds",
            Fam:      "indices search",
    Severity: Major
    Found in src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go and 7 other locations - About 35 mins to fix
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 145..157
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 400..412
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 413..425
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 666..678
    src/go/collectors/go.d.plugin/modules/mongodb/charts.go on lines 809..821
    src/go/collectors/go.d.plugin/modules/mysql/charts.go on lines 1067..1079
    src/go/collectors/go.d.plugin/modules/mysql/charts.go on lines 1105..1117

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        clusterIndicesQueryCacheChartTmpl = module.Chart{
            ID:       "cluster_%s_indices_query_cache",
            Title:    "Cluster Indices Query Cache",
            Units:    "events/s",
            Fam:      "cluster stats",
    Severity: Major
    Found in src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go and 7 other locations - About 35 mins to fix
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 145..157
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 171..183
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 400..412
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 413..425
    src/go/collectors/go.d.plugin/modules/mongodb/charts.go on lines 809..821
    src/go/collectors/go.d.plugin/modules/mysql/charts.go on lines 1067..1079
    src/go/collectors/go.d.plugin/modules/mysql/charts.go on lines 1105..1117

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        nodeClusterCommunicationChartTmpl = module.Chart{
            ID:       "node_%s_cluster_%s_cluster_communication_traffic",
            Title:    "Cluster Communication Bandwidth",
            Units:    "bytes/s",
            Fam:      "transport",
    Severity: Minor
    Found in src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go and 1 other location - About 35 mins to fix
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 480..491

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 103.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        nodeClusterCommunicationPacketsChartTmpl = module.Chart{
            ID:       "node_%s_cluster_%s_cluster_communication_packets",
            Title:    "Node Cluster Communication",
            Units:    "pps",
            Fam:      "transport",
    Severity: Minor
    Found in src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go and 1 other location - About 35 mins to fix
    src/go/collectors/go.d.plugin/modules/elasticsearch/charts.go on lines 492..503

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 103.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status