Sign upLogin

netdata/netdata

View on GitHub
Star
src/go/collectors/go.d.plugin/modules/hpssa/parse.go

Summary

Maintainability
B
4 hrs
Test Coverage

Function parseSsacliControllersInfo has 78 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func parseSsacliControllersInfo(data []byte) (map[string]*hpssaController, error) {
    var (
        cntrl *hpssaController
        arr   *hpssaArray
        ld    *hpssaLogicalDrive
Severity: Major
Found in src/go/collectors/go.d.plugin/modules/hpssa/parse.go - About 2 hrs to fix

    Function parseSsacliControllersInfo has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
    Open

    func parseSsacliControllersInfo(data []byte) (map[string]*hpssaController, error) {
    var (
        cntrl *hpssaController
        arr   *hpssaArray
        ld    *hpssaLogicalDrive
    Severity: Minor
    Found in src/go/collectors/go.d.plugin/modules/hpssa/parse.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parseSsacliControllersInfo has 6 return statements (exceeds 4 allowed).
    Open

    func parseSsacliControllersInfo(data []byte) (map[string]*hpssaController, error) {
    var (
        cntrl *hpssaController
        arr   *hpssaArray
        ld    *hpssaLogicalDrive
    Severity: Major
    Found in src/go/collectors/go.d.plugin/modules/hpssa/parse.go - About 40 mins to fix

      There are no issues that match your filters.

      Category
      Status