Sign upLogin

netdata/netdata

View on GitHub
Star
src/go/collectors/go.d.plugin/modules/nvidia_smi/collect_csv.go

Summary

Maintainability
C
1 day
Test Coverage

Method NvidiaSMI.collectGPUInfoCSV has a Cognitive Complexity of 49 (exceeds 20 allowed). Consider refactoring.
Open

func (nv *NvidiaSMI) collectGPUInfoCSV(mx map[string]int64) error {
    if len(nv.gpuQueryProperties) == 0 {
        bs, err := nv.exec.queryHelpQueryGPU()
        if err != nil {
            return err
Severity: Minor
Found in src/go/collectors/go.d.plugin/modules/nvidia_smi/collect_csv.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method NvidiaSMI.collectGPUInfoCSV has 121 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (nv *NvidiaSMI) collectGPUInfoCSV(mx map[string]int64) error {
    if len(nv.gpuQueryProperties) == 0 {
        bs, err := nv.exec.queryHelpQueryGPU()
        if err != nil {
            return err
Severity: Major
Found in src/go/collectors/go.d.plugin/modules/nvidia_smi/collect_csv.go - About 3 hrs to fix

    Method NvidiaSMI.collectGPUInfoCSV has 6 return statements (exceeds 4 allowed).
    Open

    func (nv *NvidiaSMI) collectGPUInfoCSV(mx map[string]int64) error {
    if len(nv.gpuQueryProperties) == 0 {
        bs, err := nv.exec.queryHelpQueryGPU()
        if err != nil {
            return err
    Severity: Major
    Found in src/go/collectors/go.d.plugin/modules/nvidia_smi/collect_csv.go - About 40 mins to fix

      There are no issues that match your filters.

      Category
      Status