Sign upLogin

netdata/netdata

View on GitHub
Star
src/go/collectors/go.d.plugin/modules/pgbouncer/charts.go

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func newDatabaseCharts(dbname, pgDBName string) *module.Charts {
    charts := dbChartsTmpl.Copy()
    for _, c := range *charts {
        c.ID = fmt.Sprintf(c.ID, dbname)
        c.Labels = []module.Label{
Severity: Minor
Found in src/go/collectors/go.d.plugin/modules/pgbouncer/charts.go and 1 other location - About 1 hr to fix
src/go/collectors/go.d.plugin/modules/wireguard/charts.go on lines 118..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 129.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    dbServerConnectionsTmpl = module.Chart{
        ID:       "db_%s_server_connections",
        Title:    "Database server connections",
        Units:    "connections",
        Fam:      "server connections",
Severity: Minor
Found in src/go/collectors/go.d.plugin/modules/pgbouncer/charts.go and 1 other location - About 55 mins to fix
src/go/collectors/go.d.plugin/modules/logind/charts.go on lines 68..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    dbNetworkIOChartTmpl = module.Chart{
        ID:       "db_%s_network_io",
        Title:    "Database traffic",
        Units:    "B/s",
        Fam:      "traffic",
Severity: Major
Found in src/go/collectors/go.d.plugin/modules/pgbouncer/charts.go and 6 other locations - About 40 mins to fix
src/go/collectors/go.d.plugin/modules/mysql/charts.go on lines 892..904
src/go/collectors/go.d.plugin/modules/nginxplus/charts.go on lines 244..256
src/go/collectors/go.d.plugin/modules/nginxplus/charts.go on lines 315..327
src/go/collectors/go.d.plugin/modules/nginxplus/charts.go on lines 440..452
src/go/collectors/go.d.plugin/modules/nginxplus/charts.go on lines 584..596
src/go/collectors/go.d.plugin/modules/nginxplus/charts.go on lines 667..679

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status