Sign upLogin

netdata/netdata

View on GitHub
Star
src/go/collectors/go.d.plugin/modules/prometheus/charts.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method Prometheus.addSummaryCharts has 62 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (p *Prometheus) addSummaryCharts(id, name, help string, labels labels.Labels, quantiles []prometheus.Quantile) {
    units := getChartUnits(name)

    switch units {
    case "seconds", "time":
Severity: Minor
Found in src/go/collectors/go.d.plugin/modules/prometheus/charts.go - About 1 hr to fix

    Method Prometheus.addHistogramCharts has 62 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (p *Prometheus) addHistogramCharts(id, name, help string, labels labels.Labels, buckets []prometheus.Bucket) {
    units := getChartUnits(name)

    switch units {
    case "seconds", "time":
    Severity: Minor
    Found in src/go/collectors/go.d.plugin/modules/prometheus/charts.go - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          for _, chart := range charts {
        for _, lbl := range labels {
            chart.Labels = append(chart.Labels, module.Label{
                Key:   lbl.Name,
                Value: apostropheReplacer.Replace(lbl.Value),
      Severity: Minor
      Found in src/go/collectors/go.d.plugin/modules/prometheus/charts.go and 1 other location - About 1 hr to fix
      src/go/collectors/go.d.plugin/modules/prometheus/charts.go on lines 222..234

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 129.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          for _, chart := range charts {
        for _, lbl := range labels {
            chart.Labels = append(chart.Labels, module.Label{
                Key:   lbl.Name,
                Value: apostropheReplacer.Replace(lbl.Value),
      Severity: Minor
      Found in src/go/collectors/go.d.plugin/modules/prometheus/charts.go and 1 other location - About 1 hr to fix
      src/go/collectors/go.d.plugin/modules/prometheus/charts.go on lines 154..166

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 129.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              {
            ID:       id + "_sum",
            Title:    getChartTitle(name, help),
            Units:    units,
            Fam:      getChartFamily(name),
      Severity: Minor
      Found in src/go/collectors/go.d.plugin/modules/prometheus/charts.go and 1 other location - About 40 mins to fix
      src/go/collectors/go.d.plugin/modules/prometheus/charts.go on lines 198..208

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              {
            ID:       id + "_sum",
            Title:    getChartTitle(name, help),
            Units:    units,
            Fam:      getChartFamily(name),
      Severity: Minor
      Found in src/go/collectors/go.d.plugin/modules/prometheus/charts.go and 1 other location - About 40 mins to fix
      src/go/collectors/go.d.plugin/modules/prometheus/charts.go on lines 130..140

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              {
            ID:       id + "_count",
            Title:    getChartTitle(name, help),
            Units:    "events/s",
            Fam:      getChartFamily(name),
      Severity: Minor
      Found in src/go/collectors/go.d.plugin/modules/prometheus/charts.go and 1 other location - About 35 mins to fix
      src/go/collectors/go.d.plugin/modules/prometheus/charts.go on lines 209..219

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 105.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              {
            ID:       id + "_count",
            Title:    getChartTitle(name, help),
            Units:    "events/s",
            Fam:      getChartFamily(name),
      Severity: Minor
      Found in src/go/collectors/go.d.plugin/modules/prometheus/charts.go and 1 other location - About 35 mins to fix
      src/go/collectors/go.d.plugin/modules/prometheus/charts.go on lines 141..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 105.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status