netdata/netdata

View on GitHub
src/go/collectors/go.d.plugin/modules/squidlog/logline.go

Summary

Maintainability
C
1 day
Test Coverage

logLine has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

    logLine struct {
        clientAddr string
        serverAddr string

        respTime int
Severity: Minor
Found in src/go/collectors/go.d.plugin/modules/squidlog/logline.go - About 4 hrs to fix

    Method logLine.verify has 11 return statements (exceeds 4 allowed).
    Open

    func (l logLine) verify() error {
        if l.empty() {
            return fmt.Errorf("verify: %w", errEmptyLine)
        }
        if l.hasRespTime() && !l.isRespTimeValid() {
    Severity: Major
    Found in src/go/collectors/go.d.plugin/modules/squidlog/logline.go - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (l *logLine) assignHierarchy(hierarchy string) error {
          i := strings.IndexByte(hierarchy, '/')
          if i <= 0 {
              return fmt.Errorf("assign '%s': %w", hierarchy, errBadHierarchy)
          }
      Severity: Minor
      Found in src/go/collectors/go.d.plugin/modules/squidlog/logline.go and 1 other location - About 50 mins to fix
      src/go/collectors/go.d.plugin/modules/squidlog/logline.go on lines 180..189

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 119.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (l *logLine) assignResultCode(code string) error {
          i := strings.IndexByte(code, '/')
          if i <= 0 {
              return fmt.Errorf("assign '%s': %w", code, errBadResultCode)
          }
      Severity: Minor
      Found in src/go/collectors/go.d.plugin/modules/squidlog/logline.go and 1 other location - About 50 mins to fix
      src/go/collectors/go.d.plugin/modules/squidlog/logline.go on lines 229..238

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 119.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func (l *logLine) assignRespTime(time string) error {
          if time == hyphen {
              return fmt.Errorf("assign '%s': %w", time, errBadRespTime)
          }
          v, err := strconv.Atoi(time)
      Severity: Major
      Found in src/go/collectors/go.d.plugin/modules/squidlog/logline.go and 2 other locations - About 45 mins to fix
      src/go/collectors/go.d.plugin/modules/squidlog/logline.go on lines 168..178
      src/go/collectors/go.d.plugin/modules/squidlog/logline.go on lines 191..201

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func (l *logLine) assignHTTPCode(code string) error {
          if code == hyphen {
              return fmt.Errorf("assign '%s': %w", code, errBadHTTPCode)
          }
          v, err := strconv.Atoi(code)
      Severity: Major
      Found in src/go/collectors/go.d.plugin/modules/squidlog/logline.go and 2 other locations - About 45 mins to fix
      src/go/collectors/go.d.plugin/modules/squidlog/logline.go on lines 140..150
      src/go/collectors/go.d.plugin/modules/squidlog/logline.go on lines 191..201

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func (l *logLine) assignRespSize(size string) error {
          if size == hyphen {
              return fmt.Errorf("assign '%s': %w", size, errBadRespSize)
          }
          v, err := strconv.Atoi(size)
      Severity: Major
      Found in src/go/collectors/go.d.plugin/modules/squidlog/logline.go and 2 other locations - About 45 mins to fix
      src/go/collectors/go.d.plugin/modules/squidlog/logline.go on lines 140..150
      src/go/collectors/go.d.plugin/modules/squidlog/logline.go on lines 168..178

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status