Sign upLogin

netdata/netdata

View on GitHub
Star
src/go/collectors/go.d.plugin/modules/vernemq/charts.go

Summary

Maintainability
D
2 days
Test Coverage

File charts.go has 852 lines of code (exceeds 500 allowed). Consider refactoring.
Open

// SPDX-License-Identifier: GPL-3.0-or-later

package vernemq

import "github.com/netdata/netdata/go/go.d.plugin/agent/module"
Severity: Major
Found in src/go/collectors/go.d.plugin/modules/vernemq/charts.go - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    var (
    chartMQTTv5AUTH = Chart{
        ID:    "mqtt_auth",
        Title: "v5 AUTH",
        Units: "packets/s",
    Severity: Major
    Found in src/go/collectors/go.d.plugin/modules/vernemq/charts.go and 1 other location - About 3 hrs to fix
    src/go/collectors/go.d.plugin/modules/vernemq/charts.go on lines 506..540

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 248.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    var (
    chartMQTTv3v5DISCONNECT = Chart{
        ID:    "mqtt_disconnect",
        Title: "v3/v5 DISCONNECT",
        Units: "packets/s",
    Severity: Major
    Found in src/go/collectors/go.d.plugin/modules/vernemq/charts.go and 1 other location - About 3 hrs to fix
    src/go/collectors/go.d.plugin/modules/vernemq/charts.go on lines 443..477

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 248.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        chartSystemIO = Chart{
        ID:    "system_io",
        Title: "Received and Sent Traffic through Ports",
        Units: "kilobits/s",
        Fam:   "erlang vm",
    Severity: Major
    Found in src/go/collectors/go.d.plugin/modules/vernemq/charts.go and 2 other locations - About 45 mins to fix
    src/go/collectors/go.d.plugin/modules/vernemq/charts.go on lines 354..365
    src/go/collectors/go.d.plugin/modules/vernemq/charts.go on lines 395..406

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        chartClusterCommunicationBandwidth = Chart{
        ID:    "cluster_bandwidth",
        Title: "Communication with Other Cluster Nodes",
        Units: "kilobits/s",
        Fam:   "cluster",
    Severity: Major
    Found in src/go/collectors/go.d.plugin/modules/vernemq/charts.go and 2 other locations - About 45 mins to fix
    src/go/collectors/go.d.plugin/modules/vernemq/charts.go on lines 296..307
    src/go/collectors/go.d.plugin/modules/vernemq/charts.go on lines 354..365

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        chartBandwidth = Chart{
        ID:    "bandwidth",
        Title: "Bandwidth",
        Units: "kilobits/s",
        Fam:   "bandwidth",
    Severity: Major
    Found in src/go/collectors/go.d.plugin/modules/vernemq/charts.go and 2 other locations - About 45 mins to fix
    src/go/collectors/go.d.plugin/modules/vernemq/charts.go on lines 296..307
    src/go/collectors/go.d.plugin/modules/vernemq/charts.go on lines 395..406

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 114.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        chartQueueUndeliveredMessages = Chart{
        ID:    "queue_undelivered_messages",
        Title: "Undelivered PUBLISH Messages",
        Units: "messages/s",
        Fam:   "queues",
    Severity: Minor
    Found in src/go/collectors/go.d.plugin/modules/vernemq/charts.go and 1 other location - About 45 mins to fix
    src/go/collectors/go.d.plugin/modules/cockroachdb/charts.go on lines 493..505

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 113.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status