Sign upLogin

netdudes/DataSourceryBundle

View on GitHub
Star
DataSource/Driver/Doctrine/QueryBuilder/Filterer.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method buildExpression has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function buildExpression(FilterCondition $filterCondition, $token, QueryBuilder $queryBuilder)
    {
        $identifier = $this->uniqueNameToQueryFieldMap[$filterCondition->getFieldName()];

        if (null === $filterCondition->getValue()) {
Severity: Minor
Found in DataSource/Driver/Doctrine/QueryBuilder/Filterer.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                    return $this->buildExpressionForCollection($filterCondition, $identifier, $token, $queryBuilder);
    Severity: Major
    Found in DataSource/Driver/Doctrine/QueryBuilder/Filterer.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $queryBuilder->expr()->lte($identifier, $token);
      Severity: Major
      Found in DataSource/Driver/Doctrine/QueryBuilder/Filterer.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $queryBuilder->expr()->lt($identifier, $token);
        Severity: Major
        Found in DataSource/Driver/Doctrine/QueryBuilder/Filterer.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $queryBuilder->expr()->gte($identifier, $token);
          Severity: Major
          Found in DataSource/Driver/Doctrine/QueryBuilder/Filterer.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return $queryBuilder->expr()->neq($identifier, $token);
            Severity: Major
            Found in DataSource/Driver/Doctrine/QueryBuilder/Filterer.php - About 30 mins to fix

              Function buildExpressionForCollection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function buildExpressionForCollection(FilterCondition $filterCondition, $identifier, $token, QueryBuilder $queryBuilder)
    {
        $method = $filterCondition->getMethod();
        $value = $filterCondition->getValue();
              Severity: Minor
              Found in DataSource/Driver/Doctrine/QueryBuilder/Filterer.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status