Sign upLogin

netglue/ZF2-Money-Module

View on GitHub
Star

Showing 9 of 9 total issues

File Currency.php has 1161 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
declare(strict_types=1);

/**
 * Money
Severity: Major
Found in src/NetglueMoney/Money/Currency.php - About 2 days to fix

    Method getInputFilterSpecification has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getInputFilterSpecification() : array
    {
        $required = true;
        if ($this->hasAttribute('required')) {
            $required = $this->getAttribute('required');
    Severity: Major
    Found in src/NetglueMoney/Form/MoneyFieldset.php - About 2 hrs to fix

      Money has 24 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Money
{
    /**
     * @var integer
     */
      Severity: Minor
      Found in src/NetglueMoney/Money/Money.php - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (count($this->minimumOptions)) {
            $spec = [
                'name' => GreaterThan::class,
                'options' => [
                    'min' => $this->minimumOptions['min'],
        Severity: Major
        Found in src/NetglueMoney/Form/MoneyFieldset.php and 1 other location - About 2 hrs to fix
        src/NetglueMoney/Form/MoneyFieldset.php on lines 161..176

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 126.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (count($this->maximumOptions)) {
            $spec = [
                'name' => LessThan::class,
                'options' => [
                    'max' => $this->maximumOptions['max'],
        Severity: Major
        Found in src/NetglueMoney/Form/MoneyFieldset.php and 1 other location - About 2 hrs to fix
        src/NetglueMoney/Form/MoneyFieldset.php on lines 145..160

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 126.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method addCurrency has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                string $code,
        string $displayName,
        int $numericCode,
        int $defaultFractionDigits,
        int $subUnit
        Severity: Minor
        Found in src/NetglueMoney/Money/Currency.php - About 35 mins to fix

          Function remove has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function remove($code)
    {
        if (is_array($code)) {
            foreach ($code as $c) {
                $this->remove($c);
          Severity: Minor
          Found in src/NetglueMoney/Service/CurrencyList.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getInputFilterSpecification has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getInputFilterSpecification() : array
    {
        $required = true;
        if ($this->hasAttribute('required')) {
            $required = $this->getAttribute('required');
          Severity: Minor
          Found in src/NetglueMoney/Form/MoneyFieldset.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function setValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function setValue($value)
    {
        $multiple = $this->getAttribute('multiple');

        if (true === $multiple || 'multiple' === $multiple) {
          Severity: Minor
          Found in src/NetglueMoney/Form/Element/SelectCurrency.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language