Sign upLogin

netglue/prismic-php-kit

View on GitHub
Star
src/Prismic/Exception/RequestFailureException.php

Summary

Maintainability
A
0 mins
Test Coverage
A
93%

Checking instanceof against undeclared class \GuzzleHttp\Exception\RequestException
Open

        if ($e instanceof RequestException) {
Severity: Critical
Found in src/Prismic/Exception/RequestFailureException.php by phan

Checking instanceof against undeclared class \GuzzleHttp\Exception\RequestException
Open

        if (! $this->guzzleException instanceof RequestException) {
Severity: Critical
Found in src/Prismic/Exception/RequestFailureException.php by phan

Return type of getRequest() is undeclared type ?\Psr\Http\Message\RequestInterface
Open

    public function getRequest() :? RequestInterface
Severity: Minor
Found in src/Prismic/Exception/RequestFailureException.php by phan

Call to method getResponse from undeclared class \GuzzleHttp\Exception\RequestException
Open

        $response = $e->getResponse();
Severity: Critical
Found in src/Prismic/Exception/RequestFailureException.php by phan

Argument 3 (previous) is \GuzzleHttp\Exception\GuzzleException but \Prismic\Exception\RequestFailureException::__construct() takes ?\RuntimeException|?\Throwable
Open

        $exception = new static('Api Request Failed', 500, $e);
Severity: Minor
Found in src/Prismic/Exception/RequestFailureException.php by phan

Return type of getResponse() is undeclared type ?\Psr\Http\Message\ResponseInterface
Open

    public function getResponse() :? ResponseInterface
Severity: Minor
Found in src/Prismic/Exception/RequestFailureException.php by phan

Assigning \GuzzleHttp\Exception\RequestException to property but \Prismic\Exception\RequestFailureException->guzzleException is \GuzzleHttp\Exception\GuzzleException|null
Open

        $exception->guzzleException = $e;
Severity: Minor
Found in src/Prismic/Exception/RequestFailureException.php by phan

Argument 3 (previous) is \GuzzleHttp\Exception\RequestException but \Prismic\Exception\RequestFailureException::__construct() takes ?\RuntimeException|?\Throwable
Open

        $exception = new static($message, $code, $e);
Severity: Minor
Found in src/Prismic/Exception/RequestFailureException.php by phan

Parameter $e has undeclared type \GuzzleHttp\Exception\RequestException
Open

    protected static function fromGuzzleRequestException(RequestException $e) : self
Severity: Minor
Found in src/Prismic/Exception/RequestFailureException.php by phan

Call to method getRequest from undeclared class \GuzzleHttp\Exception\RequestException
Open

        $request  = $e->getRequest();
Severity: Critical
Found in src/Prismic/Exception/RequestFailureException.php by phan

Property \Prismic\Exception\RequestFailureException->guzzleException has undeclared type \GuzzleHttp\Exception\GuzzleException
Open

    protected $guzzleException;
Severity: Minor
Found in src/Prismic/Exception/RequestFailureException.php by phan

Call to method getRequest from undeclared class \GuzzleHttp\Exception\GuzzleException
Open

        return $this->guzzleException->getRequest();
Severity: Critical
Found in src/Prismic/Exception/RequestFailureException.php by phan

Call to method getResponse from undeclared class \GuzzleHttp\Exception\GuzzleException
Open

        return $this->guzzleException->getResponse();
Severity: Critical
Found in src/Prismic/Exception/RequestFailureException.php by phan

Checking instanceof against undeclared class \GuzzleHttp\Exception\RequestException
Open

        if (! $this->guzzleException instanceof RequestException) {
Severity: Critical
Found in src/Prismic/Exception/RequestFailureException.php by phan

Parameter $e has undeclared type \GuzzleHttp\Exception\GuzzleException
Open

    public static function fromGuzzleException(GuzzleException $e) : self
Severity: Minor
Found in src/Prismic/Exception/RequestFailureException.php by phan

Avoid variables with short names like $e. Configured minimum length is 3.
Open

    protected static function fromGuzzleRequestException(RequestException $e) : self
Severity: Minor
Found in src/Prismic/Exception/RequestFailureException.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $e. Configured minimum length is 3.
Open

    public static function fromGuzzleException(GuzzleException $e) : self
Severity: Minor
Found in src/Prismic/Exception/RequestFailureException.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status