src/Prismic/SimplePredicate.php
The method q uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$query .= $this->fragment;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using short method names like SimplePredicate::q(). The configured minimum method name length is 3. Open
Open
public function q() : string
{
$query = "[:d = " . $this->name . "(";
if ($this->name === "similar") {
$query .= "\"" . $this->fragment . "\"";- Read upRead up
- Exclude checks
ShortMethodName
Since: 0.2
Detects when very short method names are used.
Example
class ShortMethod {
public function a( $index ) { // Violation
}
}Source https://phpmd.org/rules/naming.html#shortmethodname
The variable $str_array is not named in camelCase. Open
Open
private function serializeField($value) : string
{
if (is_string($value)) {
return "\"" . $value . "\"";
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $str_array is not named in camelCase. Open
Open
private function serializeField($value) : string
{
if (is_string($value)) {
return "\"" . $value . "\"";
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $str_array is not named in camelCase. Open
Open
private function serializeField($value) : string
{
if (is_string($value)) {
return "\"" . $value . "\"";
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}