Sign upLogin

netiam/acl

View on GitHub
Star

Showing 10 of 10 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  if (has(o, `${name}.${ALLOW}.${role.name}`)) {
    const privileges = get(o, `${name}.${ALLOW}.${role.name}`)
    if (privileges.includes(privilege)) {
      return ALLOW
    }
Severity: Major
Found in src/acl.js and 3 other locations - About 2 hrs to fix
src/acl.js on lines 166..171
src/acl.js on lines 182..187
src/acl.js on lines 190..195

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  if (has(o, `${name}.${DENY}.${role.name}`)) {
    const privileges = get(o, `${name}.${DENY}.${role.name}`)
    if (privileges.includes(privilege)) {
      return DENY
    }
Severity: Major
Found in src/acl.js and 3 other locations - About 2 hrs to fix
src/acl.js on lines 174..179
src/acl.js on lines 182..187
src/acl.js on lines 190..195

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  if (has(o, `${WILDCARD}.${DENY}.${role.name}`)) {
    const privileges = get(o, `${WILDCARD}.${DENY}.${role.name}`)
    if (privileges.includes(privilege)) {
      return DENY
    }
Severity: Major
Found in src/acl.js and 3 other locations - About 2 hrs to fix
src/acl.js on lines 166..171
src/acl.js on lines 174..179
src/acl.js on lines 190..195

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  if (has(o, `${WILDCARD}.${ALLOW}.${role.name}`)) {
    const privileges = get(o, `${WILDCARD}.${ALLOW}.${role.name}`)
    if (privileges.includes(privilege)) {
      return ALLOW
    }
Severity: Major
Found in src/acl.js and 3 other locations - About 2 hrs to fix
src/acl.js on lines 166..171
src/acl.js on lines 174..179
src/acl.js on lines 182..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function propertyType has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

function propertyType(o, name, role, privilege) {
  assert.ok(o)
  assert.ok(name)
  assert.ok(role)
  assert.ok(privilege)
Severity: Minor
Found in src/acl.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isAllowed has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

function isAllowed(resource, role, privilege) {
  assert.ok(resource)
  assert.ok(role)
  assert.ok(privilege)
Severity: Minor
Found in src/acl.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function propertyType has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function propertyType(o, name, role, privilege) {
  assert.ok(o)
  assert.ok(name)
  assert.ok(role)
  assert.ok(privilege)
Severity: Minor
Found in src/acl.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (has(resource, `${DENY}.${role.name}`)) {
      const privileges = get(resource, `${DENY}.${role.name}`)
      if (privileges.includes(privilege)) {
        return false
      }
    Severity: Minor
    Found in src/acl.js and 1 other location - About 50 mins to fix
    src/acl.js on lines 119..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (has(resource, `${ALLOW}.${role.name}`)) {
      const privileges = get(resource, `${ALLOW}.${role.name}`)
      if (privileges.includes(privilege)) {
        return true
      }
    Severity: Minor
    Found in src/acl.js and 1 other location - About 50 mins to fix
    src/acl.js on lines 111..116

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

      return undefined
    Severity: Major
    Found in src/acl.js - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language