Sign upLogin

netinvent/windows_tools

View on GitHub
Star
windows_tools/office/__init__.py

Summary

Maintainability
C
7 hrs
Test Coverage

Function get_office_version has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

def get_office_version():
    # type: () -> Tuple[str, Optional[str]]
    """
    It's plain horrible to get the office version installed
    Let's use some tricks, ie detect current Word used
Severity: Minor
Found in windows_tools/office/__init__.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _get_installed_office_version has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def _get_installed_office_version():
    # type: () -> Optional[str, bool]
    """
    Try do determine which is the highest current version of Office installed
    """
Severity: Minor
Found in windows_tools/office/__init__.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if ver in click_and_run_ident:
                            return ver
                return "2016/2019/O365"
Severity: Major
Found in windows_tools/office/__init__.py - About 45 mins to fix

    Avoid too many return statements within this function.
    Open

            return None
    Severity: Major
    Found in windows_tools/office/__init__.py - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status