Sign upLogin

netinvent/windows_tools

View on GitHub
Star
windows_tools/product_key/__init__.py

Summary

Maintainability
B
4 hrs
Test Coverage

Function decode_key has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def decode_key(rpk: str) -> str:
    """
    Decodes a product key from registry (worked with XP, fails with newer Windows versions)

    This function is derived from https://gist.github.com/Spaceghost/877110
Severity: Minor
Found in windows_tools/product_key/__init__.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_windows_product_channel has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

def get_windows_product_channel() -> Optional[str]:
    """
    Tries to get Windows license type (OEM/Retail/Volume)

    So basically there's no good way to get that info, but the description field in SoftwareLicenseingProduct
Severity: Minor
Found in windows_tools/product_key/__init__.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                return "OEM_COA_SLP"
Severity: Major
Found in windows_tools/product_key/__init__.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return "UNKNOWN"
    Severity: Major
    Found in windows_tools/product_key/__init__.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return "VOLUME"
      Severity: Major
      Found in windows_tools/product_key/__init__.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return "OEM"
        Severity: Major
        Found in windows_tools/product_key/__init__.py - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status