Sign upLogin

netinvent/windows_tools

View on GitHub
Star
windows_tools/server/__init__.py

Summary

Maintainability
A
1 hr
Test Coverage

Function is_rds_server has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def is_rds_server():
    """
    Check if current machine has terminal services in RDS or single user mode

    We'll first check Win32_OperatingSystem()[0].OSProductSuite
Severity: Minor
Found in windows_tools/server/__init__.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return None
Severity: Major
Found in windows_tools/server/__init__.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return True
    Severity: Major
    Found in windows_tools/server/__init__.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Wontfix

                  return False
      Severity: Major
      Found in windows_tools/server/__init__.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status