Sign upLogin

netinvent/windows_tools

View on GitHub
Star
windows_tools/wmi_queries/__init__.py

Summary

Maintainability
C
1 day
Test Coverage

Function query_wmi has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

def query_wmi(
    query_str: str,
    namespace: str = "cimv2",
    name: str = "noname",
    depth: int = 1,
Severity: Minor
Found in windows_tools/wmi_queries/__init__.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function wmi_object_2_list_of_dict has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

def wmi_object_2_list_of_dict(
    wmi_objects, depth: int = 1, root: bool = True
) -> Union[dict, list]:
    """
    Return a WMI object as a list of dicts, accepts multiple depth
Severity: Minor
Found in windows_tools/wmi_queries/__init__.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function query_wmi has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

def query_wmi(
Severity: Major
Found in windows_tools/wmi_queries/__init__.py - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

        return None
    Severity: Major
    Found in windows_tools/wmi_queries/__init__.py - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status