Sign upLogin

netzke/netzke-basepack

View on GitHub
Star
lib/netzke/form/services.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method build_form_errors has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def build_form_errors(record)
        form_errors = {}
        foreign_keys = model_adapter.hash_fk_model
        record.errors.to_hash.map{|field, error|
          # some ORM return an array for error
Severity: Minor
Found in lib/netzke/form/services.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_or_update_record has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def create_or_update_record(hsh)
        hsh.merge!(config[:strong_values]) if config[:strong_values]

        # only pick the record specified in the params if it was not provided in the configuration
        @record ||= model_adapter.find_record hsh.delete(model.primary_key.to_s)
Severity: Minor
Found in lib/netzke/form/services.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status