Sign upLogin

newtheatre/history-project

View on GitHub
Star
_plugins/link_list.rb

Summary

Maintainability
A
0 mins
Test Coverage

Method href has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Wontfix

    def href
      if @link_type and @link_type.key?('href')
        unless username
          Jekyll.logger.abort_with("Missing key username in link on page #{@page_ref.relative_path}, type has href template.")
        end
Severity: Minor
Found in _plugins/link_list.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

        # TODO feed back into calling Jekyll plugin
Severity: Minor
Found in _plugins/link_list.rb by fixme

end at 107, 10 is not aligned with if at 105, 8.
Invalid

        ) end
Severity: Minor
Found in _plugins/link_list.rb by rubocop

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)

There are no issues that match your filters.

Category
Status