Sign upLogin

next-l/enju_leaf

View on GitHub
Star
app/controllers/agent_types_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage
A
100%

Similar blocks of code found in 28 locations. Consider refactoring.
Open

  def update
    if params[:move]
      move_position(@agent_type, params[:move])
      return
    end
Severity: Major
Found in app/controllers/agent_types_controller.rb and 27 other locations - About 1 hr to fix
app/controllers/agent_relationship_types_controller.rb on lines 50..62
app/controllers/bookstores_controller.rb on lines 50..62
app/controllers/budget_types_controller.rb on lines 50..62
app/controllers/checkout_types_controller.rb on lines 67..79
app/controllers/circulation_statuses_controller.rb on lines 52..64
app/controllers/classification_types_controller.rb on lines 50..62
app/controllers/content_types_controller.rb on lines 50..62
app/controllers/countries_controller.rb on lines 50..62
app/controllers/create_types_controller.rb on lines 50..62
app/controllers/event_categories_controller.rb on lines 50..62
app/controllers/form_of_works_controller.rb on lines 50..62
app/controllers/frequencies_controller.rb on lines 50..62
app/controllers/identifier_types_controller.rb on lines 50..62
app/controllers/languages_controller.rb on lines 50..62
app/controllers/licenses_controller.rb on lines 50..62
app/controllers/manifestation_relationship_types_controller.rb on lines 50..62
app/controllers/medium_of_performances_controller.rb on lines 50..62
app/controllers/nii_types_controller.rb on lines 50..62
app/controllers/produce_types_controller.rb on lines 50..62
app/controllers/realize_types_controller.rb on lines 50..62
app/controllers/request_status_types_controller.rb on lines 31..43
app/controllers/request_types_controller.rb on lines 29..41
app/controllers/roles_controller.rb on lines 29..41
app/controllers/search_engines_controller.rb on lines 50..62
app/controllers/subject_heading_types_controller.rb on lines 50..62
app/controllers/subject_types_controller.rb on lines 50..62
app/controllers/use_restrictions_controller.rb on lines 50..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 30 locations. Consider refactoring.
Open

  def create
    @agent_type = AgentType.new(agent_type_params)

    respond_to do |format|
      if @agent_type.save
Severity: Major
Found in app/controllers/agent_types_controller.rb and 29 other locations - About 1 hr to fix
app/controllers/agent_merges_controller.rb on lines 43..52
app/controllers/agent_relationship_types_controller.rb on lines 34..43
app/controllers/bookmark_stats_controller.rb on lines 43..52
app/controllers/bookstores_controller.rb on lines 34..43
app/controllers/budget_types_controller.rb on lines 34..43
app/controllers/circulation_statuses_controller.rb on lines 36..45
app/controllers/classification_types_controller.rb on lines 34..43
app/controllers/content_types_controller.rb on lines 34..43
app/controllers/countries_controller.rb on lines 34..43
app/controllers/create_types_controller.rb on lines 34..43
app/controllers/donates_controller.rb on lines 34..43
app/controllers/event_categories_controller.rb on lines 34..43
app/controllers/form_of_works_controller.rb on lines 34..43
app/controllers/frequencies_controller.rb on lines 34..43
app/controllers/identifier_types_controller.rb on lines 34..43
app/controllers/languages_controller.rb on lines 34..43
app/controllers/licenses_controller.rb on lines 34..43
app/controllers/manifestation_relationship_types_controller.rb on lines 34..43
app/controllers/medium_of_performances_controller.rb on lines 34..43
app/controllers/nii_types_controller.rb on lines 34..43
app/controllers/owns_controller.rb on lines 51..60
app/controllers/picture_files_controller.rb on lines 47..56
app/controllers/produce_types_controller.rb on lines 34..43
app/controllers/realize_types_controller.rb on lines 34..43
app/controllers/search_engines_controller.rb on lines 34..43
app/controllers/subject_heading_types_controller.rb on lines 34..43
app/controllers/subject_types_controller.rb on lines 34..43
app/controllers/subscribes_controller.rb on lines 37..46
app/controllers/use_restrictions_controller.rb on lines 34..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 35 locations. Consider refactoring.
Open

  def destroy
    @agent_type.destroy

    respond_to do |format|
      format.html { redirect_to agent_types_url, notice: t('controller.successfully_deleted', model: t('activerecord.models.agent_type')) }
Severity: Major
Found in app/controllers/agent_types_controller.rb and 34 other locations - About 15 mins to fix
app/controllers/accepts_controller.rb on lines 105..110
app/controllers/agent_import_files_controller.rb on lines 71..76
app/controllers/agent_import_results_controller.rb on lines 33..38
app/controllers/agent_relationship_types_controller.rb on lines 69..74
app/controllers/agents_controller.rb on lines 181..186
app/controllers/bookstores_controller.rb on lines 69..74
app/controllers/budget_types_controller.rb on lines 69..74
app/controllers/carrier_types_controller.rb on lines 76..81
app/controllers/classification_types_controller.rb on lines 69..74
app/controllers/content_types_controller.rb on lines 69..74
app/controllers/countries_controller.rb on lines 69..74
app/controllers/create_types_controller.rb on lines 69..74
app/controllers/event_categories_controller.rb on lines 69..74
app/controllers/event_import_results_controller.rb on lines 31..36
app/controllers/form_of_works_controller.rb on lines 69..74
app/controllers/frequencies_controller.rb on lines 69..74
app/controllers/identifier_types_controller.rb on lines 69..74
app/controllers/import_requests_controller.rb on lines 85..90
app/controllers/languages_controller.rb on lines 69..74
app/controllers/licenses_controller.rb on lines 69..74
app/controllers/manifestation_relationship_types_controller.rb on lines 69..74
app/controllers/medium_of_performances_controller.rb on lines 69..74
app/controllers/nii_types_controller.rb on lines 69..74
app/controllers/produce_types_controller.rb on lines 69..74
app/controllers/profiles_controller.rb on lines 146..151
app/controllers/realize_types_controller.rb on lines 69..74
app/controllers/resource_import_files_controller.rb on lines 77..82
app/controllers/resource_import_results_controller.rb on lines 35..40
app/controllers/search_engines_controller.rb on lines 69..74
app/controllers/subject_heading_types_controller.rb on lines 69..74
app/controllers/subject_types_controller.rb on lines 69..74
app/controllers/subjects_controller.rb on lines 115..120
app/controllers/user_import_results_controller.rb on lines 31..36
app/controllers/withdraws_controller.rb on lines 106..111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status