Sign upLogin

next-l/enju_leaf

View on GitHub
Star
app/controllers/items_controller.rb

Summary

Maintainability
D
2 days
Test Coverage
B
88%

Method index has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
Open

  def index
    query = params[:query].to_s.strip
    per_page = Item.default_per_page
    @count = {}
    if user_signed_in?
Severity: Minor
Found in app/controllers/items_controller.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method index has 107 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def index
    query = params[:query].to_s.strip
    per_page = Item.default_per_page
    @count = {}
    if user_signed_in?
Severity: Major
Found in app/controllers/items_controller.rb - About 4 hrs to fix

    File items_controller.rb has 262 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class ItemsController < ApplicationController
  include EnjuInventory::Controller
  before_action :set_item, only: [:show, :edit, :update, :destroy]
  before_action :check_policy, only: [:index, :new, :create]
  before_action :get_agent, :get_manifestation, :get_shelf, except: [:create, :update, :destroy]
    Severity: Minor
    Found in app/controllers/items_controller.rb - About 2 hrs to fix

      Method create has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def create
    @item = Item.new(item_params)
    manifestation = Manifestation.find(@item.manifestation_id)

    respond_to do |format|
      Severity: Minor
      Found in app/controllers/items_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method new has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def new
    if Shelf.real.blank?
      flash[:notice] = t('item.create_shelf_first')
      redirect_to libraries_url
      return
      Severity: Minor
      Found in app/controllers/items_controller.rb - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                    case params[:inventory]
            when 'not_in_catalog'
              mode = 'not_in_catalog'
            else
              mode = 'not_on_shelf'
        Severity: Major
        Found in app/controllers/items_controller.rb - About 45 mins to fix

          Method prepare_options has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def prepare_options
    @libraries = Library.order(:position)
    if @item
      @library = @item.shelf.library
    else
          Severity: Minor
          Found in app/controllers/items_controller.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

            def update
    respond_to do |format|
      if @item.update(item_params)
        format.html { redirect_to @item, notice: t('controller.successfully_updated', model: t('activerecord.models.item')) }
        format.json { head :no_content }
          Severity: Major
          Found in app/controllers/items_controller.rb and 3 other locations - About 1 hr to fix
          app/controllers/agents_controller.rb on lines 166..174
          app/controllers/subjects_controller.rb on lines 100..108
          app/controllers/user_group_has_checkout_types_controller.rb on lines 57..65

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status