Sign upLogin

next-l/enju_leaf

View on GitHub
Star
app/controllers/owns_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage
A
90%

Similar blocks of code found in 30 locations. Consider refactoring.
Open

  def create
    @own = Own.new(own_params)

    respond_to do |format|
      if @own.save
Severity: Major
Found in app/controllers/owns_controller.rb and 29 other locations - About 1 hr to fix
app/controllers/agent_merges_controller.rb on lines 43..52
app/controllers/agent_relationship_types_controller.rb on lines 34..43
app/controllers/agent_types_controller.rb on lines 34..43
app/controllers/bookmark_stats_controller.rb on lines 43..52
app/controllers/bookstores_controller.rb on lines 34..43
app/controllers/budget_types_controller.rb on lines 34..43
app/controllers/circulation_statuses_controller.rb on lines 36..45
app/controllers/classification_types_controller.rb on lines 34..43
app/controllers/content_types_controller.rb on lines 34..43
app/controllers/countries_controller.rb on lines 34..43
app/controllers/create_types_controller.rb on lines 34..43
app/controllers/donates_controller.rb on lines 34..43
app/controllers/event_categories_controller.rb on lines 34..43
app/controllers/form_of_works_controller.rb on lines 34..43
app/controllers/frequencies_controller.rb on lines 34..43
app/controllers/identifier_types_controller.rb on lines 34..43
app/controllers/languages_controller.rb on lines 34..43
app/controllers/licenses_controller.rb on lines 34..43
app/controllers/manifestation_relationship_types_controller.rb on lines 34..43
app/controllers/medium_of_performances_controller.rb on lines 34..43
app/controllers/nii_types_controller.rb on lines 34..43
app/controllers/picture_files_controller.rb on lines 47..56
app/controllers/produce_types_controller.rb on lines 34..43
app/controllers/realize_types_controller.rb on lines 34..43
app/controllers/search_engines_controller.rb on lines 34..43
app/controllers/subject_heading_types_controller.rb on lines 34..43
app/controllers/subject_types_controller.rb on lines 34..43
app/controllers/subscribes_controller.rb on lines 37..46
app/controllers/use_restrictions_controller.rb on lines 34..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  def destroy
    @own.destroy

    respond_to do |format|
      format.html {
Severity: Major
Found in app/controllers/owns_controller.rb and 2 other locations - About 45 mins to fix
app/controllers/produces_controller.rb on lines 91..106
app/controllers/realizes_controller.rb on lines 92..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  def new
    if @item && @agent.blank?
      redirect_to item_agents_url(@item)
      nil
    elsif @agent && @item.blank?
Severity: Minor
Found in app/controllers/owns_controller.rb and 2 other locations - About 30 mins to fix
app/controllers/produces_controller.rb on lines 33..44
app/controllers/realizes_controller.rb on lines 33..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status