Sign upLogin

next-l/enju_leaf

View on GitHub
Star
app/controllers/reserves_controller.rb

Summary

Maintainability
D
2 days
Test Coverage
B
84%

Method index has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def index
    unless current_user.has_role?('Librarian')
      if @user
        if current_user == @user
          redirect_to reserves_url(format: params[:format])
Severity: Minor
Found in app/controllers/reserves_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method index has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def index
    unless current_user.has_role?('Librarian')
      if @user
        if current_user == @user
          redirect_to reserves_url(format: params[:format])
Severity: Major
Found in app/controllers/reserves_controller.rb - About 3 hrs to fix

    Method update has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      def update
    unless current_user.has_role?('Librarian')
      if @reserve.user != current_user
        access_denied
        return
    Severity: Minor
    Found in app/controllers/reserves_controller.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File reserves_controller.rb has 263 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class ReservesController < ApplicationController
  before_action :set_reserve, only: [:show, :edit, :update, :destroy]
  before_action :check_policy, only: [:index, :new, :create]
  before_action :prepare_options, only: [:new, :edit]
  before_action :get_user, only: [:index, :new]
    Severity: Minor
    Found in app/controllers/reserves_controller.rb - About 2 hrs to fix

      Method new has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def new
    @reserve = Reserve.new

    if current_user.has_role?('Librarian') && @user
      @reserve.assign_attributes(
      Severity: Minor
      Found in app/controllers/reserves_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def update
    unless current_user.has_role?('Librarian')
      if @reserve.user != current_user
        access_denied
        return
      Severity: Minor
      Found in app/controllers/reserves_controller.rb - About 1 hr to fix

        Method new has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def new
    @reserve = Reserve.new

    if current_user.has_role?('Librarian') && @user
      @reserve.assign_attributes(
        Severity: Minor
        Found in app/controllers/reserves_controller.rb - About 1 hr to fix

          Method create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def create
    @reserve = Reserve.new(reserve_params)
    @reserve.set_user

    if current_user.has_role?('Librarian')
          Severity: Minor
          Found in app/controllers/reserves_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method destroy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def destroy
    @reserve.destroy
    # flash[:notice] = t('reserve.reservation_was_canceled')

    if @reserve.manifestation.is_reserved?
          Severity: Minor
          Found in app/controllers/reserves_controller.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if ['text', 'rss'].include?(params[:format].to_s.downcase)
      per_page = 500
      page = 1
    else
      per_page = Reserve.default_per_page
          Severity: Minor
          Found in app/controllers/reserves_controller.rb and 1 other location - About 15 mins to fix
          app/controllers/checkouts_controller.rb on lines 25..31

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 25.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status