Sign upLogin

next-l/enju_leaf

View on GitHub
Star
app/controllers/subjects_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage
A
90%

Method index has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def index
    sort = {sort_by: 'created_at', order: 'desc'}
    case params[:sort_by]
    when 'name'
      sort[:sort_by] = 'term'
Severity: Minor
Found in app/controllers/subjects_controller.rb - About 1 hr to fix

    Method index has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def index
    sort = {sort_by: 'created_at', order: 'desc'}
    case params[:sort_by]
    when 'name'
      sort[:sort_by] = 'term'
    Severity: Minor
    Found in app/controllers/subjects_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

      def create
    @subject = Subject.new(subject_params)

    respond_to do |format|
      if @subject.save
    Severity: Major
    Found in app/controllers/subjects_controller.rb and 8 other locations - About 1 hr to fix
    app/controllers/agent_relationships_controller.rb on lines 47..57
    app/controllers/carrier_types_controller.rb on lines 39..49
    app/controllers/creates_controller.rb on lines 51..61
    app/controllers/manifestation_relationships_controller.rb on lines 49..59
    app/controllers/produces_controller.rb on lines 53..63
    app/controllers/realizes_controller.rb on lines 53..63
    app/controllers/user_group_has_checkout_types_controller.rb on lines 40..50
    app/controllers/user_groups_controller.rb on lines 35..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      def update
    respond_to do |format|
      if @subject.update(subject_params)
        format.html { redirect_to @subject, notice: t('controller.successfully_updated', model: t('activerecord.models.subject')) }
        format.json { head :no_content }
    Severity: Major
    Found in app/controllers/subjects_controller.rb and 3 other locations - About 1 hr to fix
    app/controllers/agents_controller.rb on lines 166..174
    app/controllers/items_controller.rb on lines 221..229
    app/controllers/user_group_has_checkout_types_controller.rb on lines 57..65

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 35 locations. Consider refactoring.
    Open

      def destroy
    @subject.destroy

    respond_to do |format|
      format.html { redirect_to subjects_url, notice: t('controller.successfully_deleted', model: t('activerecord.models.subject')) }
    Severity: Major
    Found in app/controllers/subjects_controller.rb and 34 other locations - About 15 mins to fix
    app/controllers/accepts_controller.rb on lines 105..110
    app/controllers/agent_import_files_controller.rb on lines 71..76
    app/controllers/agent_import_results_controller.rb on lines 33..38
    app/controllers/agent_relationship_types_controller.rb on lines 69..74
    app/controllers/agent_types_controller.rb on lines 69..74
    app/controllers/agents_controller.rb on lines 181..186
    app/controllers/bookstores_controller.rb on lines 69..74
    app/controllers/budget_types_controller.rb on lines 69..74
    app/controllers/carrier_types_controller.rb on lines 76..81
    app/controllers/classification_types_controller.rb on lines 69..74
    app/controllers/content_types_controller.rb on lines 69..74
    app/controllers/countries_controller.rb on lines 69..74
    app/controllers/create_types_controller.rb on lines 69..74
    app/controllers/event_categories_controller.rb on lines 69..74
    app/controllers/event_import_results_controller.rb on lines 31..36
    app/controllers/form_of_works_controller.rb on lines 69..74
    app/controllers/frequencies_controller.rb on lines 69..74
    app/controllers/identifier_types_controller.rb on lines 69..74
    app/controllers/import_requests_controller.rb on lines 85..90
    app/controllers/languages_controller.rb on lines 69..74
    app/controllers/licenses_controller.rb on lines 69..74
    app/controllers/manifestation_relationship_types_controller.rb on lines 69..74
    app/controllers/medium_of_performances_controller.rb on lines 69..74
    app/controllers/nii_types_controller.rb on lines 69..74
    app/controllers/produce_types_controller.rb on lines 69..74
    app/controllers/profiles_controller.rb on lines 146..151
    app/controllers/realize_types_controller.rb on lines 69..74
    app/controllers/resource_import_files_controller.rb on lines 77..82
    app/controllers/resource_import_results_controller.rb on lines 35..40
    app/controllers/search_engines_controller.rb on lines 69..74
    app/controllers/subject_heading_types_controller.rb on lines 69..74
    app/controllers/subject_types_controller.rb on lines 69..74
    app/controllers/user_import_results_controller.rb on lines 31..36
    app/controllers/withdraws_controller.rb on lines 106..111

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status