Sign upLogin

next-l/enju_leaf

View on GitHub
Star
app/models/bookmark.rb

Summary

Maintainability
A
3 hrs
Test Coverage
C
70%

Method get_title_from_url has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def get_title_from_url(url)
    return if url.blank?
    return unless Addressable::URI.parse(url).host

    if manifestation_id == url.bookmarkable_id
Severity: Minor
Found in app/models/bookmark.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_manifestation has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create_manifestation
    manifestation = get_manifestation
    if manifestation
      self.manifestation_id = manifestation.id
      return
Severity: Minor
Found in app/models/bookmark.rb - About 1 hr to fix

    Method create_manifestation has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def create_manifestation
    manifestation = get_manifestation
    if manifestation
      self.manifestation_id = manifestation.id
      return
    Severity: Minor
    Found in app/models/bookmark.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method bookmarkable_url? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def bookmarkable_url?
    if url.try(:my_host?)
      unless url.try(:bookmarkable_id)
        errors.add(:base, I18n.t('bookmark.not_our_holding'))
      end
    Severity: Minor
    Found in app/models/bookmark.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status