Sign upLogin

next-l/enju_leaf

View on GitHub
Star
app/models/concerns/enju_nii/enju_manifestation.rb

Summary

Maintainability
C
1 day
Test Coverage
B
87%

Method import_record_from_cinii_books has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

      def import_record_from_cinii_books(doc)
        # http://ci.nii.ac.jp/info/ja/api/api_outline.html#cib_od
        # return nil

        ncid = doc.at('//cinii:ncid').try(:content)
Severity: Minor
Found in app/models/concerns/enju_nii/enju_manifestation.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method import_record_from_cinii_books has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def import_record_from_cinii_books(doc)
        # http://ci.nii.ac.jp/info/ja/api/api_outline.html#cib_od
        # return nil

        ncid = doc.at('//cinii:ncid').try(:content)
Severity: Major
Found in app/models/concerns/enju_nii/enju_manifestation.rb - About 2 hrs to fix

    Method create_cinii_series_statements has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def create_cinii_series_statements(doc, manifestation)
        series = doc.at("//dcterms:isPartOf")
        if series && parent_url = series["rdf:resource"]
          ptbl = series["dc:title"]
          rdf_url = "#{URI.parse(parent_url.gsub(/\#\w+\Z/, '')).to_s}"
    Severity: Minor
    Found in app/models/concerns/enju_nii/enju_manifestation.rb - About 1 hr to fix

      Method import_from_cinii_books has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def import_from_cinii_books(options)
        lisbn = ncid = nil

        if options[:ncid]
          ncid = options[:ncid]
      Severity: Minor
      Found in app/models/concerns/enju_nii/enju_manifestation.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status