Sign upLogin

next-l/enju_leaf

View on GitHub
Star
app/models/reserve.rb

Summary

Maintainability
C
7 hrs
Test Coverage
B
81%

File reserve.rb has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Reserve < ApplicationRecord
  include Statesman::Adapters::ActiveRecordQueries[
    transition_class: ReserveTransition,
    initial_state: ReserveStateMachine.initial_state
  ]
Severity: Minor
Found in app/models/reserve.rb - About 2 hrs to fix

    Class Reserve has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Reserve < ApplicationRecord
  include Statesman::Adapters::ActiveRecordQueries[
    transition_class: ReserveTransition,
    initial_state: ReserveStateMachine.initial_state
  ]
    Severity: Minor
    Found in app/models/reserve.rb - About 2 hrs to fix

      Method send_message has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def send_message(sender = nil)
    sender ||= User.find(1) # TODO: システムからのメッセージの発信者
    Reserve.transaction do
      mailer = nil
      Severity: Minor
      Found in app/models/reserve.rb - About 1 hr to fix

        Method available_for_reservation? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def available_for_reservation?
    if manifestation
      if checked_out_now?
        errors.add(:base, I18n.t('reserve.this_manifestation_is_already_checked_out'))
      end
        Severity: Minor
        Found in app/models/reserve.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status