Sign upLogin

next-l/enju_leaf

View on GitHub
Star
app/models/user_import_file.rb

Summary

Maintainability
D
3 days
Test Coverage
B
85%

Method import has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

  def import
    transition_to!(:started)
    num = { user_imported: 0, user_found: 0, failed: 0, error: 0 }
    rows = open_import_file(create_import_temp_file(attachment))
    row_num = 1
Severity: Minor
Found in app/models/user_import_file.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method import has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def import
    transition_to!(:started)
    num = { user_imported: 0, user_found: 0, failed: 0, error: 0 }
    rows = open_import_file(create_import_temp_file(attachment))
    row_num = 1
Severity: Major
Found in app/models/user_import_file.rb - About 3 hrs to fix

    Method set_profile_params has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

      def set_profile_params(row)
    params = {}
    user_group = UserGroup.find_by(name: row['user_group']) || default_user_group
    params[:user_group_id] = user_group.id if user_group
    Severity: Minor
    Found in app/models/user_import_file.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method modify has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

      def modify
    transition_to!(:started)
    num = { user_updated: 0, user_not_found: 0, failed: 0 }
    rows = open_import_file(create_import_temp_file(attachment))
    row_num = 1
    Severity: Minor
    Found in app/models/user_import_file.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File user_import_file.rb has 258 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class UserImportFile < ApplicationRecord
  include Statesman::Adapters::ActiveRecordQueries[
    transition_class: UserImportFileTransition,
    initial_state: UserImportFileStateMachine.initial_state
  ]
    Severity: Minor
    Found in app/models/user_import_file.rb - About 2 hrs to fix

      Method modify has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def modify
    transition_to!(:started)
    num = { user_updated: 0, user_not_found: 0, failed: 0 }
    rows = open_import_file(create_import_temp_file(attachment))
    row_num = 1
      Severity: Minor
      Found in app/models/user_import_file.rb - About 1 hr to fix

        Method set_profile_params has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def set_profile_params(row)
    params = {}
    user_group = UserGroup.find_by(name: row['user_group']) || default_user_group
    params[:user_group_id] = user_group.id if user_group
        Severity: Minor
        Found in app/models/user_import_file.rb - About 1 hr to fix

          Method remove has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def remove
    transition_to!(:started)
    row_num = 1
    rows = open_import_file(create_import_temp_file(attachment))
          Severity: Minor
          Found in app/models/user_import_file.rb - About 1 hr to fix

            Method open_import_file has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def open_import_file(tempfile)
    file = CSV.open(tempfile.path, 'r:utf-8', col_sep: "\t")
    header_columns = %w(
      username role email password user_group user_number expired_at
      full_name full_name_transcription required_role locked
            Severity: Minor
            Found in app/models/user_import_file.rb - About 1 hr to fix

              Method remove has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def remove
    transition_to!(:started)
    row_num = 1
    rows = open_import_file(create_import_temp_file(attachment))
              Severity: Minor
              Found in app/models/user_import_file.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 9 locations. Consider refactoring.
              Open

                rescue StandardError => e
    self.error_message = "line #{row_num}: #{e.message}"
    save
    transition_to!(:failed)
    mailer = UserImportMailer.failed(self)
              Severity: Major
              Found in app/models/user_import_file.rb and 8 other locations - About 15 mins to fix
              app/models/event_import_file.rb on lines 73..80
              app/models/event_import_file.rb on lines 111..118
              app/models/event_import_file.rb on lines 138..145
              app/models/resource_import_file.rb on lines 232..239
              app/models/resource_import_file.rb on lines 361..368
              app/models/resource_import_file.rb on lines 390..397
              app/models/resource_import_file.rb on lines 429..436
              app/models/user_import_file.rb on lines 164..171

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 25.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 9 locations. Consider refactoring.
              Open

                rescue StandardError => e
    self.error_message = "line #{row_num}: #{e.message}"
    save
    transition_to!(:failed)
    mailer = UserImportMailer.failed(self)
              Severity: Major
              Found in app/models/user_import_file.rb and 8 other locations - About 15 mins to fix
              app/models/event_import_file.rb on lines 73..80
              app/models/event_import_file.rb on lines 111..118
              app/models/event_import_file.rb on lines 138..145
              app/models/resource_import_file.rb on lines 232..239
              app/models/resource_import_file.rb on lines 361..368
              app/models/resource_import_file.rb on lines 390..397
              app/models/resource_import_file.rb on lines 429..436
              app/models/user_import_file.rb on lines 198..205

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 25.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status