Showing 2,739 of 2,739 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
it('should set the right assistive text', () => {
const { getByText } = render(<AnimationButtom isAnimationPaused={false} />);
expect(getByText('Stop auto-play')).toBeDefined();
});
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 61.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function CheckmarkIcon
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function CheckmarkIcon(props) {
const { className, style } = props;
return (
<svg
className={className}
Function buildPlainListFromTree
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function buildPlainListFromTree(tree, parentName, parentPath) {
if (!Array.isArray(tree)) return [];
return tree.reduce((result, node, index) => {
const nodeName = getNodeName({ parentName, index });
const level = getNodeLevel({ name: nodeName });
Function Color
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
const Color = React.forwardRef((props, ref) => {
const { color, name, tabIndex, isChecked, onChange } = props;
const rgba = colorToRgba(color);
const colorId = useUniqueIdentifier('color-picker-default');
if (!isValidColor(rgba)) {
Function DoneIcon
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function DoneIcon(props) {
const { className, style } = props;
return (
<svg
className={className}
Function CountriesList
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
const CountriesList = memo(props => {
const { countries, country, itemsRef, handleCountryChange, handleActiveChange } = props;
const list = useSimulatedLoading(countries, 15);
return list.map((value, index) => {
Function ActionsCell
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function ActionsCell(props) {
const { columnChildren, rowsLength, rowIndex, rowData } = props;
if (columnChildren) {
const getMenuAlignment = () => {
Function goNextStep
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
const goNextStep = () => {
if (currentStepIndex === 2) {
mappedRecords.current = getDataToImport({
data,
fieldsMap,
Function handleChangeHour
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
handleChangeHour(event) {
const { hour } = this.state;
const { hour24 } = this.props;
const { value } = event.target;
let normalizedValue;
Function Upload
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function Upload(props) {
const { className, style } = props;
return (
<svg
className={className}
Function render
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
render() {
const { disabled, children, footer, style, className, size } = this.props;
const { groupName, ariaDescribedby } = this.props;
return (
Function Linkedin
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
const Linkedin = props => {
const { className, style } = props;
return (
<svg
className={className}
Function ToolbarButton
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function ToolbarButton(props) {
const { onClick, href, title, children } = props;
if (href !== undefined && title === 'Open isolated') {
return (
Function CheckmarkIcon
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function CheckmarkIcon(props) {
const { className, style } = props;
return (
<svg
className={className}
Function Pricing
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
const Pricing = props => {
const { className, style } = props;
return (
<svg
className={className}
Function CheckmarkIcon
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function CheckmarkIcon(props) {
const { className, style } = props;
return (
<svg
className={className}
Function InfoFilled
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
const InfoFilled = props => {
const { className, style } = props;
return (
<svg
className={className}
Function PercentInput
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
const PercentInput = forwardRef((props, ref) => {
const {
value,
name,
placeholder,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function CurrencyInput
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
const CurrencyInput = forwardRef((props, ref) => {
const {
value,
name,
placeholder,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function handleChangeMinutes
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
handleChangeMinutes(event) {
const { minutes } = this.state;
const { value } = event.target;
const { hour24 } = this.props;
let normalizedValue;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"