Showing 2,739 of 2,739 total issues
Similar blocks of code found in 2 locations. Consider refactoring. Open
const iconMap = {
info: () => <InfoIcon />,
error: () => <ErrorIcon />,
warning: () => <WarningIcon />,
success: () => <SuccessIcon />,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 64.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
it('should set isBackButtonDisabled to true initially in Footer component', () => {
const component = mount(<ImportRecordsFlow isOpen />);
expect(component.find(Footer).prop('isBackButtonDisabled')).toBe(true);
});
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 64.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function filterCountries
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function filterCountries(query, countries, country) {
if (query === '' || query === '+') {
const filteredCountries = countries.filter(value => value.isoCode !== country.isoCode);
filteredCountries.unshift(country);
return filteredCountries;
Function manageTab
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function manageTab(node, event) {
const tabbable = findTabbableElements(node);
if (!tabbable.length) {
event.preventDefault();
Function DownloadCsv
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function DownloadCsv(props) {
const { className, style } = props;
return (
<svg
className={className}
Function CsvIcon
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function CsvIcon(props) {
const { className, style } = props;
return (
<svg
className={className}
Function CheckCircle
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function CheckCircle(props) {
const { className, style } = props;
return (
<svg
className={className}
Function Building
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
const Building = props => {
const { className, style } = props;
return (
<svg
className={className}
Function Facebook
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
const Facebook = props => {
const { className, style } = props;
return (
<svg
className={className}
Function AvatarMenu
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function AvatarMenu(props) {
const {
src,
initials,
icon,
Function enableBodyScroll
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
export function enableBodyScroll(targetElement) {
if (isIosDevice) {
if (!targetElement) {
// eslint-disable-next-line no-console
console.error(
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function AccordionTimelineMarker
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
export default function AccordionTimelineMarker(props) {
const {
icon,
name,
isLoading,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function SelectableCell
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
export default function SelectableCell(props) {
const { isSelected, isDisabled, tableId, onSelectRow, onDeselectRow, inputType } = props;
const name = `${tableId}-options`;
const isRadio = inputType === 'radio';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function FileSelector
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
const FileSelector = React.forwardRef((props, ref) => {
const {
className,
style,
id,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function Hex
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
export default function Hex() {
const { hex, tabIndex, onChange } = useContext(ColorPickerContext);
const [color, setColor] = useState(hex.substr(1));
const [isFocused, setIsFocused] = useState(false);
Function Messages
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
const Messages = props => {
const { className, style } = props;
return (
<svg
className={className}
Function FolderOpen
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
const FolderOpen = props => {
const { className, style } = props;
return (
<svg className={className} style={style} width="20px" height="15px" viewBox="0 0 20 15">
<g id="components" stroke="none" strokeWidth="1" fill="none" fillRule="evenodd">
Function Comments
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
const Comments = props => {
const { className, style } = props;
return (
<svg
className={className}
Similar blocks of code found in 5 locations. Consider refactoring. Open
it('should not render the RequiredAsterisk when there is no label', () => {
const component = mount(<Label required />);
expect(component.find(RequiredAsterisk).exists()).toBe(false);
});
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 63.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 5 locations. Consider refactoring. Open
it('should show preview if file has been selected', () => {
const component = mount(<StepTwo hasFileSelected />);
expect(component.find('Preview').exists()).toBe(true);
});
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 63.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76