nfedyashev/retryable

View on GitHub

Showing 8 of 8 total issues

Method retryable has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def retryable(options = {})
      opts = configuration.to_hash

      check_for_invalid_options(options, opts)
      opts.merge!(options)
Severity: Minor
Found in lib/retryable.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method has too many lines. [11/10]
Open

    def initialize
      @contexts     = {}
      @ensure       = proc {}
      @exception_cb = proc {}
      @log_method   = proc {}
Severity: Minor
Found in lib/retryable/configuration.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method retryable has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def retryable(options = {})
      opts = configuration.to_hash

      check_for_invalid_options(options, opts)
      opts.merge!(options)
Severity: Minor
Found in lib/retryable.rb - About 1 hr to fix

    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Open

    $LOAD_PATH.unshift(File.dirname(__FILE__), "lib")
    Severity: Minor
    Found in bin/retryable by rubocop

    Operator = should be surrounded by a single space.
    Open

      spec.licenses    = ['MIT']
    Severity: Minor
    Found in retryable.gemspec by rubocop

    Do not suppress exceptions.
    Open

            rescue *on_exception
    Severity: Minor
    Found in lib/retryable.rb by rubocop

    This cop checks for rescue blocks with no body.

    Example:

    # bad
    
    def some_method
      do_something
    rescue
      # do nothing
    end

    Example:

    # bad
    
    begin
      do_something
    rescue
      # do nothing
    end

    Example:

    # good
    
    def some_method
      do_something
    rescue
      handle_exception
    end

    Example:

    # good
    
    begin
      do_something
    rescue
      handle_exception
    end

    Unnecessary spacing detected.
    Open

      spec.licenses    = ['MIT']
    Severity: Minor
    Found in retryable.gemspec by rubocop

    This cop checks for extra/unnecessary whitespace.

    Example:

    # good if AllowForAlignment is true
    name      = "RuboCop"
    # Some comment and an empty line
    
    website  += "/bbatsov/rubocop" unless cond
    puts        "rubocop"          if     debug
    
    # bad for any configuration
    set_app("RuboCop")
    website  = "https://github.com/bbatsov/rubocop"

    TODO found
    Open

            # TODO restore 2.2 once RubyGems issue is resolved?
    Severity: Minor
    Found in .github/workflows/ci.yml by fixme
    Severity
    Category
    Status
    Source
    Language