Sign upLogin

nfroidure/cloud-pages

View on GitHub
Star

Showing 319 of 319 total issues

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      putBucketAclAsync: (...args) =>
        new Promise((resolve, reject) => {
          s3.putBucketAcl(...args, (err, data) => {
            if (err) {
              reject(err);
Severity: Major
Found in src/s3.js and 5 other locations - About 1 hr to fix
src/s3.js on lines 33..42
src/s3.js on lines 43..52
src/s3.js on lines 53..62
src/s3.js on lines 63..72
src/s3.js on lines 83..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      listObjectsAsync: (...args) =>
        new Promise((resolve, reject) => {
          s3.listObjectsV2(...args, (err, data) => {
            if (err) {
              reject(err);
Severity: Major
Found in src/s3.js and 5 other locations - About 1 hr to fix
src/s3.js on lines 43..52
src/s3.js on lines 53..62
src/s3.js on lines 63..72
src/s3.js on lines 73..82
src/s3.js on lines 83..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      putObjectAsync: (...args) =>
        new Promise((resolve, reject) => {
          s3.putObject(...args, (err, data) => {
            if (err) {
              reject(err);
Severity: Major
Found in src/s3.js and 5 other locations - About 1 hr to fix
src/s3.js on lines 33..42
src/s3.js on lines 43..52
src/s3.js on lines 53..62
src/s3.js on lines 73..82
src/s3.js on lines 83..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      createBucketAsync: (...args) =>
        new Promise((resolve, reject) => {
          s3.createBucket(...args, (err, data) => {
            if (err) {
              reject(err);
Severity: Major
Found in src/s3.js and 5 other locations - About 1 hr to fix
src/s3.js on lines 33..42
src/s3.js on lines 43..52
src/s3.js on lines 63..72
src/s3.js on lines 73..82
src/s3.js on lines 83..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      deleteObjectsAsync: (...args) =>
        new Promise((resolve, reject) => {
          s3.deleteObjects(...args, (err, data) => {
            if (err) {
              reject(err);
Severity: Major
Found in src/s3.js and 5 other locations - About 1 hr to fix
src/s3.js on lines 33..42
src/s3.js on lines 53..62
src/s3.js on lines 63..72
src/s3.js on lines 73..82
src/s3.js on lines 83..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      putBucketWebsiteAsync: (...args) =>
        new Promise((resolve, reject) => {
          s3.putBucketWebsite(...args, (err, data) => {
            if (err) {
              reject(err);
Severity: Major
Found in src/s3.js and 5 other locations - About 1 hr to fix
src/s3.js on lines 33..42
src/s3.js on lines 43..52
src/s3.js on lines 53..62
src/s3.js on lines 63..72
src/s3.js on lines 73..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getCommits has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        new Promise((resolve, reject) => {
          git(gitDir).log((err, result) => {
            if (err) {
              reject(err);
              return;
Severity: Minor
Found in src/git.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              assert.deepEqual(glob.args, [
            [
              'dist/**/*',
              {
                absolute: true,
    Severity: Minor
    Found in src/cloudpages.mocha.js and 1 other location - About 35 mins to fix
    src/cloudpages.mocha.js on lines 82..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              assert.deepEqual(glob.args, [
            [
              '../www/**/*',
              {
                absolute: true,
    Severity: Minor
    Found in src/cloudpages.mocha.js and 1 other location - About 35 mins to fix
    src/cloudpages.mocha.js on lines 148..159

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Delete ,
    Open

        bucket,
    Severity: Minor
    Found in src/cloudpages.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'debug',·'Sending·file:' with "debug",·"Sending·file:"
    Open

                  log('debug', 'Sending file:', file, key);
    Severity: Minor
    Found in src/cloudpages.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'debug',·'File·sent:' with "debug",·"File·sent:"
    Open

                      log('debug', 'File sent:', file, key);
    Severity: Minor
    Found in src/cloudpages.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'debug',·'Website·rules·set.' with "debug",·"Website·rules·set."
    Open

              log('debug', 'Website rules set.');
    Severity: Minor
    Found in src/cloudpages.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'assert' with "assert"
    Open

    const assert = require('assert');
    Severity: Minor
    Found in src/cloudpages.mocha.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace '2010-03-06T00:00:00Z' with "2010-03-06T00:00:00Z"
    Open

      const TEST_BASE_TIME = new Date('2010-03-06T00:00:00Z').getTime();
    Severity: Minor
    Found in src/cloudpages.mocha.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Delete ,
    Open

          lookup: sinon.stub(),
    Severity: Minor
    Found in src/cloudpages.mocha.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Delete ,
    Open

          getCommits: sinon.stub(),
    Severity: Minor
    Found in src/cloudpages.mocha.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'E_VERSION_REQUIRED' with "E_VERSION_REQUIRED"
    Open

              assert.equal(err.code, 'E_VERSION_REQUIRED');
    Severity: Minor
    Found in src/cloudpages.mocha.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace ········ with ······
    Open

            const SIX_DAYS = 6 * 24 * 60 * 60 * 1000;
    Severity: Minor
    Found in src/cloudpages.mocha.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace ··message:·'3.0.0·(tag:·v3.0.0)', with message:·"3.0.0·(tag:·v3.0.0)"
    Open

                  message: '3.0.0 (tag: v3.0.0)',
    Severity: Minor
    Found in src/cloudpages.mocha.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Severity
    Category
    Status
    Source
    Language