Sign upLogin

nfroidure/cloud-pages

View on GitHub
Star
src/s3.js

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      deleteObjectsAsync: (...args) =>
        new Promise((resolve, reject) => {
          s3.deleteObjects(...args, (err, data) => {
            if (err) {
              reject(err);
Severity: Major
Found in src/s3.js and 5 other locations - About 1 hr to fix
src/s3.js on lines 33..42
src/s3.js on lines 53..62
src/s3.js on lines 63..72
src/s3.js on lines 73..82
src/s3.js on lines 83..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      putBucketAclAsync: (...args) =>
        new Promise((resolve, reject) => {
          s3.putBucketAcl(...args, (err, data) => {
            if (err) {
              reject(err);
Severity: Major
Found in src/s3.js and 5 other locations - About 1 hr to fix
src/s3.js on lines 33..42
src/s3.js on lines 43..52
src/s3.js on lines 53..62
src/s3.js on lines 63..72
src/s3.js on lines 83..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      putObjectAsync: (...args) =>
        new Promise((resolve, reject) => {
          s3.putObject(...args, (err, data) => {
            if (err) {
              reject(err);
Severity: Major
Found in src/s3.js and 5 other locations - About 1 hr to fix
src/s3.js on lines 33..42
src/s3.js on lines 43..52
src/s3.js on lines 53..62
src/s3.js on lines 73..82
src/s3.js on lines 83..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      listObjectsAsync: (...args) =>
        new Promise((resolve, reject) => {
          s3.listObjectsV2(...args, (err, data) => {
            if (err) {
              reject(err);
Severity: Major
Found in src/s3.js and 5 other locations - About 1 hr to fix
src/s3.js on lines 43..52
src/s3.js on lines 53..62
src/s3.js on lines 63..72
src/s3.js on lines 73..82
src/s3.js on lines 83..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      putBucketWebsiteAsync: (...args) =>
        new Promise((resolve, reject) => {
          s3.putBucketWebsite(...args, (err, data) => {
            if (err) {
              reject(err);
Severity: Major
Found in src/s3.js and 5 other locations - About 1 hr to fix
src/s3.js on lines 33..42
src/s3.js on lines 43..52
src/s3.js on lines 53..62
src/s3.js on lines 63..72
src/s3.js on lines 73..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      createBucketAsync: (...args) =>
        new Promise((resolve, reject) => {
          s3.createBucket(...args, (err, data) => {
            if (err) {
              reject(err);
Severity: Major
Found in src/s3.js and 5 other locations - About 1 hr to fix
src/s3.js on lines 33..42
src/s3.js on lines 43..52
src/s3.js on lines 63..72
src/s3.js on lines 73..82
src/s3.js on lines 83..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Replace 'debug')('s3' with "debug")("s3"
Open

const debug = require('debug')('s3');
Severity: Minor
Found in src/s3.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Delete ,
Open

        }),
Severity: Minor
Found in src/s3.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Replace 'aws-sdk/clients/s3' with "aws-sdk/clients/s3"
Open

const AWSS3 = require('aws-sdk/clients/s3');
Severity: Minor
Found in src/s3.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Replace 'debug',·'S3·Service·initialized.' with "debug",·"S3·Service·initialized."
Open

    log('debug', 'S3 Service initialized.');
Severity: Minor
Found in src/s3.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Replace ⏎········ENV.AWS_S3_SECRET_ACCESS_KEY·|| with ·ENV.AWS_S3_SECRET_ACCESS_KEY·||⏎·······
Open

      secretAccessKey:
Severity: Minor
Found in src/s3.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Replace 'bluebird' with "bluebird"
Open

const Promise = require('bluebird');
Severity: Minor
Found in src/s3.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Replace 's3' with "s3"
Open

const DEFAULT_NAME = 's3';
Severity: Minor
Found in src/s3.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Delete ,
Open

      logger: { log: debug },
Severity: Minor
Found in src/s3.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Replace 'use·strict' with "use·strict"
Open

'use strict';
Severity: Minor
Found in src/s3.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Replace 'ENV',·'log' with "ENV",·"log"
Open

const DEFAULT_DEPENDENCIES = ['ENV', 'log'];
Severity: Minor
Found in src/s3.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There are no issues that match your filters.

Category
Status