Sign upLogin

ngauthier/opentracing-ruby

View on GitHub
Star

Showing 13 of 13 total issues

Unused method argument - fields. If it's necessary, use _ or _fields as an argument name to indicate that it won't be used. You can also write as log(*) if you want the method to accept any arguments but don't care about them.
Open

    def log(event: nil, timestamp: Time.now, **fields)
Severity: Minor
Found in lib/opentracing/span.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - carrier. If it's necessary, use _ or _carrier as an argument name to indicate that it won't be used.
Open

    def extract(operation_name, format, carrier, tracer)
Severity: Minor
Found in lib/opentracing.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - tracer. If it's necessary, use _ or _tracer as an argument name to indicate that it won't be used.
Open

    def extract(operation_name, format, carrier, tracer)
Severity: Minor
Found in lib/opentracing.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - key. If it's necessary, use _ or _key as an argument name to indicate that it won't be used. You can also write as set_tag(*) if you want the method to accept any arguments but don't care about them.
Open

    def set_tag(key, value)
Severity: Minor
Found in lib/opentracing/span.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - event. You can also write as log(*) if you want the method to accept any arguments but don't care about them.
Open

    def log(event: nil, timestamp: Time.now, **fields)
Severity: Minor
Found in lib/opentracing/span.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - value. If it's necessary, use _ or _value as an argument name to indicate that it won't be used. You can also write as set_tag(*) if you want the method to accept any arguments but don't care about them.
Open

    def set_tag(key, value)
Severity: Minor
Found in lib/opentracing/span.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - span_context. If it's necessary, use _ or _span_context as an argument name to indicate that it won't be used.
Open

    def inject(span_context, format, carrier)
Severity: Minor
Found in lib/opentracing.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - key. If it's necessary, use _ or _key as an argument name to indicate that it won't be used. You can also write as get_baggage_item(*) if you want the method to accept any arguments but don't care about them.
Open

    def get_baggage_item(key)
Severity: Minor
Found in lib/opentracing/span.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - value. If it's necessary, use _ or _value as an argument name to indicate that it won't be used. You can also write as set_baggage_item(*) if you want the method to accept any arguments but don't care about them.
Open

    def set_baggage_item(key, value)
Severity: Minor
Found in lib/opentracing/span.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - timestamp. You can also write as log(*) if you want the method to accept any arguments but don't care about them.
Open

    def log(event: nil, timestamp: Time.now, **fields)
Severity: Minor
Found in lib/opentracing/span.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - end_time. You can also write as finish(*) if you want the method to accept any arguments but don't care about them.
Open

    def finish(end_time: Time.now)
Severity: Minor
Found in lib/opentracing/span.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - key. If it's necessary, use _ or _key as an argument name to indicate that it won't be used. You can also write as set_baggage_item(*) if you want the method to accept any arguments but don't care about them.
Open

    def set_baggage_item(key, value)
Severity: Minor
Found in lib/opentracing/span.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - operation_name. If it's necessary, use _ or _operation_name as an argument name to indicate that it won't be used.
Open

    def extract(operation_name, format, carrier, tracer)
Severity: Minor
Found in lib/opentracing.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end
Severity
Category
Status
Source
Language