Assignment Branch Condition size for associate_product_with_taxon is too high. [55.69/15] Open
def associate_product_with_taxon(product, taxon_hierarchy, putInTop)
return if product.nil? || taxon_hierarchy.nil?
taxon_hierarchy.split(/\s*\|\s*/).each do |hierarchy|
hierarchy = hierarchy.split(/\s*>\s*/)
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Method associate_product_with_taxon
has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring. Open
def associate_product_with_taxon(product, taxon_hierarchy, putInTop)
return if product.nil? || taxon_hierarchy.nil?
taxon_hierarchy.split(/\s*\|\s*/).each do |hierarchy|
hierarchy = hierarchy.split(/\s*>\s*/)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Block has too many lines. [67/25] Open
included do
### IMAGE HELPERS ###
# find_and_attach_image_to
# This method attaches images to products. The images may come
# from a local source (i.e. on disk), or they may be online (HTTP/HTTPS).
- Read upRead up
- Exclude checks
This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.
Cyclomatic complexity for associate_product_with_taxon is too high. [12/6] Open
def associate_product_with_taxon(product, taxon_hierarchy, putInTop)
return if product.nil? || taxon_hierarchy.nil?
taxon_hierarchy.split(/\s*\|\s*/).each do |hierarchy|
hierarchy = hierarchy.split(/\s*>\s*/)
- Read upRead up
- Exclude checks
This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.
Perceived complexity for associate_product_with_taxon is too high. [12/7] Open
def associate_product_with_taxon(product, taxon_hierarchy, putInTop)
return if product.nil? || taxon_hierarchy.nil?
taxon_hierarchy.split(/\s*\|\s*/).each do |hierarchy|
hierarchy = hierarchy.split(/\s*>\s*/)
- Read upRead up
- Exclude checks
This cop tries to produce a complexity score that's a measure of the
complexity the reader experiences when looking at a method. For that
reason it considers when
nodes as something that doesn't add as much
complexity as an if
or a &&
. Except if it's one of those special
case
/when
constructs where there's no expression after case
. Then
the cop treats it as an if
/elsif
/elsif
... and lets all the when
nodes count. In contrast to the CyclomaticComplexity cop, this cop
considers else
nodes as adding complexity.
Example:
def my_method # 1
if cond # 1
case var # 2 (0.8 + 4 * 0.2, rounded)
when 1 then func_one
when 2 then func_two
when 3 then func_three
when 4..10 then func_other
end
else # 1
do_something until a && b # 2
end # ===
end # 7 complexity points
Method has too many lines. [32/30] Open
def associate_product_with_taxon(product, taxon_hierarchy, putInTop)
return if product.nil? || taxon_hierarchy.nil?
taxon_hierarchy.split(/\s*\|\s*/).each do |hierarchy|
hierarchy = hierarchy.split(/\s*>\s*/)
- Read upRead up
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Method associate_product_with_taxon
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
def associate_product_with_taxon(product, taxon_hierarchy, putInTop)
return if product.nil? || taxon_hierarchy.nil?
taxon_hierarchy.split(/\s*\|\s*/).each do |hierarchy|
hierarchy = hierarchy.split(/\s*>\s*/)
Method find_and_attach_image_to
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def find_and_attach_image_to(product_or_variant, filename)
return if filename.blank?
temp_file = fetch_image(filename)
return unless temp_file
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Use snake_case for variable names. Open
def associate_product_with_taxon(product, taxon_hierarchy, putInTop)
- Read upRead up
- Exclude checks
This cop makes sure that all variables use the configured style, snake_case or camelCase, for their names.
Example: EnforcedStyle: snake_case (default)
# bad
fooBar = 1
# good
foo_bar = 1
Example: EnforcedStyle: camelCase
# bad
foo_bar = 1
# good
fooBar = 1
Line is too long. [160/130] Open
"Product: #{product.inspect}, Taxonomy: #{taxonomy.inspect}, Taxon: #{last_taxon.inspect}, #{last_taxon.errors.full_messages.join(', ')}", :error)
- Exclude checks
Use a guard clause instead of wrapping the code inside a conditional expression. Open
if putInTop && defined?(SolidusSortProductsTaxon)
- Read upRead up
- Exclude checks
Use a guard clause instead of wrapping the code inside a conditional expression
Example:
# bad
def test
if something
work
end
end
# good
def test
return unless something
work
end
# also good
def test
work if something
end
# bad
if something
raise 'exception'
else
ok
end
# good
raise 'exception' if something
ok
Line is too long. [138/130] Open
"Product: #{product.inspect}, Taxonomy: #{taxon_hierarchy}, Errors: #{taxonomy.errors.full_messages.join(', ')} \n", :error)
- Exclude checks
Use %r
around regular expression. Open
filename =~ /\Ahttp[s]*:\/\// ? fetch_remote_image(filename) : fetch_local_image(filename)
- Read upRead up
- Exclude checks
This cop enforces using // or %r around regular expressions.
Example: EnforcedStyle: slashes (default)
# bad
snake_case = %r{^[\dA-Z_]+$}
# bad
regex = %r{
foo
(bar)
(baz)
}x
# good
snake_case = /^[\dA-Z_]+$/
# good
regex = /
foo
(bar)
(baz)
/x
Example: EnforcedStyle: percent_r
# bad
snake_case = /^[\dA-Z_]+$/
# bad
regex = /
foo
(bar)
(baz)
/x
# good
snake_case = %r{^[\dA-Z_]+$}
# good
regex = %r{
foo
(bar)
(baz)
}x
Example: EnforcedStyle: mixed
# bad
snake_case = %r{^[\dA-Z_]+$}
# bad
regex = /
foo
(bar)
(baz)
/x
# good
snake_case = /^[\dA-Z_]+$/
# good
regex = %r{
foo
(bar)
(baz)
}x
Example: AllowInnerSlashes: false (default)
# If `false`, the cop will always recommend using `%r` if one or more
# slashes are found in the regexp string.
# bad
x =~ /home\//
# good
x =~ %r{home/}
Example: AllowInnerSlashes: true
# good
x =~ /home\//