Sign upLogin

ngxs/store

View on GitHub
Star

Showing 10 of 67 total issues

File state-factory.ts has 294 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  Injectable,
  Injector,
  Optional,
  SkipSelf,
Severity: Minor
Found in packages/store/src/internal/state-factory.ts - About 3 hrs to fix

    Function handle has 87 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

      handle(state: any, event: any, next: NgxsNextPluginFn) {
    if (isPlatformServer(this._platformId)) {
      return next(state, event);
    }
    Severity: Major
    Found in packages/storage-plugin/src/storage.plugin.ts - About 2 hrs to fix

      Function ngOnInit has 76 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

        ngOnInit() {
    this._actions$
      .pipe(
        ofActionDispatched(ResetForm),
        filter((action: ResetForm) => action.payload.path === this.path),
      Severity: Major
      Found in packages/form-plugin/src/directive.ts - About 2 hrs to fix

        Function handle has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
        Open

          handle(state: any, event: any, next: NgxsNextPluginFn) {
    if (isPlatformServer(this._platformId)) {
      return next(state, event);
    }
        Severity: Minor
        Found in packages/storage-plugin/src/storage.plugin.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function invokeActions has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
        Open

          invokeActions(dispatched$: Observable<ActionContext>, action: any) {
    const type = getActionTypeFromInstance(action)!;
    const results = [];

    // Determines whether the dispatched action has been handled, this is assigned
        Severity: Minor
        Found in packages/store/src/internal/state-factory.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

            if (
      hasOwnProp.call(o, prop) &&
      (oIsFunction ? prop !== 'caller' && prop !== 'callee' && prop !== 'arguments' : true) &&
      o[prop] !== null &&
      (typeof o[prop] === 'object' || typeof o[prop] === 'function') &&
        Severity: Critical
        Found in packages/store/src/utils/freeze.ts - About 1 hr to fix

          Function invokeActions has 52 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

            invokeActions(dispatched$: Observable<ActionContext>, action: any) {
    const type = getActionTypeFromInstance(action)!;
    const results = [];

    // Determines whether the dispatched action has been handled, this is assigned
          Severity: Major
          Found in packages/store/src/internal/state-factory.ts - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Confirmed

                              if (isObservable(value)) {
                    return value;
                  }
            Severity: Major
            Found in packages/store/src/internal/state-factory.ts - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                            if (actionMeta.options.cancelUncompleted) {
                // todo: ofActionDispatched should be used with action class
                result = result.pipe(
                  takeUntil(dispatched$.pipe(ofActionDispatched(action as any)))
                );
              Severity: Major
              Found in packages/store/src/internal/state-factory.ts - About 45 mins to fix

                Consider simplifying this complex logical expression.
                Open

                        if (storedValue !== 'undefined' && storedValue != null) {
          try {
            const newVal = this._options.deserialize!(storedValue);
            storedValue = this._options.afterDeserialize!(newVal, key);
          } catch {
                Severity: Major
                Found in packages/storage-plugin/src/storage.plugin.ts - About 40 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language