Showing 12 of 56 total issues
Function handle
has 94 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
handle(state: any, event: any, next: NgxsNextPluginFn) {
if (isPlatformServer(this._platformId)) {
return next(state, event);
}
Function handle
has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring. Open
Open
handle(state: any, event: any, next: NgxsNextPluginFn) {
if (isPlatformServer(this._platformId)) {
return next(state, event);
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File state-factory.ts
has 267 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
import { Injectable, Injector, Optional, SkipSelf, Inject, OnDestroy } from '@angular/core';
import {
forkJoin,
from,
Observable,
Function ngOnInit
has 76 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
ngOnInit() {
this._actions$
.pipe(
ofActionDispatched(ResetForm),
filter((action: ResetForm) => action.payload.path === this.path),
Function invokeActions
has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring. Open
Open
invokeActions(dispatched$: Observable<ActionContext>, action: any) {
const type = getActionTypeFromInstance(action)!;
const results = [];
// Determines whether the dispatched action has been handled, this is assigned
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Consider simplifying this complex logical expression. Open
Open
if (
hasOwnProp.call(o, prop) &&
(oIsFunction ? prop !== 'caller' && prop !== 'callee' && prop !== 'arguments' : true) &&
o[prop] !== null &&
(typeof o[prop] === 'object' || typeof o[prop] === 'function') &&
Function invokeActions
has 52 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
invokeActions(dispatched$: Observable<ActionContext>, action: any) {
const type = getActionTypeFromInstance(action)!;
const results = [];
// Determines whether the dispatched action has been handled, this is assigned
Avoid deeply nested control flow statements. Open
Open
if (isObservable(value)) {
return value;
}
Avoid deeply nested control flow statements. Open
Open
if (storedValue && addedStates && Object.keys(addedStates).length > 0) {
storedValue = Object.keys(addedStates).reduce((accumulator, addedState) => {
// The `storedValue` can be equal to the entire state when the default
// state key is used. However, if `addedStates` only contains the `router` value,
// we only want to merge the state with the `router` value.
Avoid deeply nested control flow statements. Open
Open
if (value instanceof Promise) {
return from(value);
}
Avoid deeply nested control flow statements. Open
Open
if (actionMeta.options.cancelUncompleted) {
// todo: ofActionDispatched should be used with action class
result = result.pipe(
takeUntil(dispatched$.pipe(ofActionDispatched(action as any)))
);
Consider simplifying this complex logical expression. Open
Open
if (storedValue !== 'undefined' && storedValue != null) {
try {
const newVal = this._options.deserialize!(storedValue);
storedValue = this._options.afterDeserialize!(newVal, key);
} catch {