packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts

Summary

Maintainability
A
0 mins
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Invalid

  it('migrate forRoot that has the "key" property with values as an array literal', async () => {
    const { appTree } = await testSetup();

    const newContent = `
    import { NgxsStoragePluginModule } from '@ngxs/storage-plugin';
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 19..50
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 52..83
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 85..116
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 151..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Invalid

  it('migrate from a constant array', async () => {
    const { appTree } = await testSetup();

    const newContent = `
    import { NgxsStoragePluginModule } from '@ngxs/storage-plugin';
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 19..50
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 52..83
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 85..116
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 118..149

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Invalid

  it('migrate empty forRoot', async () => {
    const { appTree } = await testSetup();

    const newContent = `
    import { NgxsStoragePluginModule } from '@ngxs/storage-plugin';
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 52..83
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 85..116
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 118..149
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 151..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Invalid

  it('migrate forRoot that has the "key" property with a value as a string literal', async () => {
    const { appTree } = await testSetup();

    const newContent = `
    import { NgxsStoragePluginModule } from '@ngxs/storage-plugin';
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 19..50
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 52..83
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 118..149
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 151..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Invalid

  it('migrate forRoot that is missing the "key" property', async () => {
    const { appTree } = await testSetup();

    const newContent = `
    import { NgxsStoragePluginModule } from '@ngxs/storage-plugin';
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 19..50
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 85..116
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 118..149
packages/storage-plugin/schematics/src/ng-generate/keys-migration.spec.ts on lines 151..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status