Sign upLogin

ngxs/store

View on GitHub
Star
packages/store/src/internal/state-factory.ts

Summary

Maintainability
C
7 hrs
Test Coverage
A
99%

File state-factory.ts has 294 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  Injectable,
  Injector,
  Optional,
  SkipSelf,
Severity: Minor
Found in packages/store/src/internal/state-factory.ts - About 3 hrs to fix

    Function invokeActions has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
    Open

      invokeActions(dispatched$: Observable<ActionContext>, action: any) {
    const type = getActionTypeFromInstance(action)!;
    const results = [];

    // Determines whether the dispatched action has been handled, this is assigned
    Severity: Minor
    Found in packages/store/src/internal/state-factory.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function invokeActions has 52 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

      invokeActions(dispatched$: Observable<ActionContext>, action: any) {
    const type = getActionTypeFromInstance(action)!;
    const results = [];

    // Determines whether the dispatched action has been handled, this is assigned
    Severity: Major
    Found in packages/store/src/internal/state-factory.ts - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Confirmed

                        if (isObservable(value)) {
                    return value;
                  }
      Severity: Major
      Found in packages/store/src/internal/state-factory.ts - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Wontfix

                          if (ɵisPromise(value)) {
                    return from(value);
                  }
        Severity: Major
        Found in packages/store/src/internal/state-factory.ts - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                        if (actionMeta.options.cancelUncompleted) {
                // todo: ofActionDispatched should be used with action class
                result = result.pipe(
                  takeUntil(dispatched$.pipe(ofActionDispatched(action as any)))
                );
          Severity: Major
          Found in packages/store/src/internal/state-factory.ts - About 45 mins to fix

            There are no issues that match your filters.

            Category
            Status