Sign upLogin

nhojpatrick/nhojpatrick-cucumber

View on GitHub
Star

Showing 52 of 78 total issues

Method transform has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.
Open

    private Map<String, Object> transform(final int depth,
                                          final Map<String, Object> input,
                                          final String previousPath,
                                          final List<PathElement> pathElements,
                                          final Transformation transformation)
Severity: Minor
Found in json/transform/src/main/java/com/github/nhojpatrick/cucumber/json/transform/impl/TransformImpl.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method transform has 141 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private Map<String, Object> transform(final int depth,
                                          final Map<String, Object> input,
                                          final String previousPath,
                                          final List<PathElement> pathElements,
                                          final Transformation transformation)
Severity: Major
Found in json/transform/src/main/java/com/github/nhojpatrick/cucumber/json/transform/impl/TransformImpl.java - About 5 hrs to fix

    Method perform has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    public Map<String, Object> perform(final PathElement pathElement,
                                       final Map<String, Object> inputRaw,
                                       final String currentPath)
            throws IllegalKeyException,
    Severity: Minor
    Found in json-transformations/reverse/src/main/java/com/github/nhojpatrick/cucumber/json/transformations/reverse/ReverseTransformation.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method perform has 84 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
    public Map<String, Object> perform(final PathElement pathElement,
                                       final Map<String, Object> inputRaw,
                                       final String currentPath)
            throws IllegalKeyException,
    Severity: Major
    Found in json-transformations/whitespace/src/main/java/com/github/nhojpatrick/cucumber/json/transformations/whitespace/WhitespaceTransformation.java - About 3 hrs to fix

      Method perform has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public Map<String, Object> perform(final PathElement pathElement,
                                       final Map<String, Object> inputRaw,
                                       final String currentPath)
            throws IllegalKeyException,
      Severity: Minor
      Found in json-transformations/whitespace/src/main/java/com/github/nhojpatrick/cucumber/json/transformations/whitespace/WhitespaceTransformation.java - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method perform has 80 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @Override
    public Map<String, Object> perform(final PathElement pathElement,
                                       final Map<String, Object> inputRaw,
                                       final String currentPath)
            throws IllegalKeyException,
      Severity: Major
      Found in json-transformations/reverse/src/main/java/com/github/nhojpatrick/cucumber/json/transformations/reverse/ReverseTransformation.java - About 3 hrs to fix

        Method perform has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            @Override
    public Map<String, Object> perform(final PathElement pathElement,
                                       final Map<String, Object> inputRaw,
                                       final String currentPath)
            throws IllegalKeyException,
        Severity: Minor
        Found in json-transformations/remove/src/main/java/com/github/nhojpatrick/cucumber/json/transformations/remove/RemoveTransformation.java - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method perform has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @Override
    public Map<String, Object> perform(final PathElement pathElement,
                                       final Map<String, Object> inputRaw,
                                       final String currentPath)
            throws IllegalKeyException,
        Severity: Major
        Found in json-transformations/remove/src/main/java/com/github/nhojpatrick/cucumber/json/transformations/remove/RemoveTransformation.java - About 2 hrs to fix

          Method perform has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              @Override
    public Map<String, Object> perform(final PathElement pathElement,
                                       final Map<String, Object> inputRaw,
                                       final String currentPath)
            throws IllegalKeyException,
          Severity: Minor
          Found in json-transformations/set/src/main/java/com/github/nhojpatrick/cucumber/json/transformations/set/SetTransformation.java - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method setupRunStateForKeysAndValue has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              @Given("^TestingInternalSteps I have setup the run state for keys and type:$")
    @SuppressFBWarnings(value = "CC_CYCLOMATIC_COMPLEXITY", justification = "Complex because of framework used")
    public void setupRunStateForKeysAndValue(final DataTable data)
            throws IllegalKeyException {
          Severity: Minor
          Found in testing-internal/glue/src/main/java/com/github/nhojpatrick/cucumber/testing/internal/steps/state/State_TestingInternalSteps.java - About 1 hr to fix

            Method perform has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                @Override
    public Map<String, Object> perform(final PathElement pathElement,
                                       final Map<String, Object> inputRaw,
                                       final String currentPath)
            throws IllegalKeyException,
            Severity: Minor
            Found in json-transformations/print/src/main/java/com/github/nhojpatrick/cucumber/json/transformations/print/PrintTransformation.java - About 1 hr to fix

              Method doCastTo has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  @SuppressFBWarnings(value = {"CC_CYCLOMATIC_COMPLEXITY",
            "URV_CHANGE_RETURN_TYPE"}, justification = "As designed")
    private Object doCastTo(final String value, final String type)
            throws UnsupportedDataTypeConversionException,
            UnsupportedDataTypeException {
              Severity: Minor
              Found in json/core/src/main/java/com/github/nhojpatrick/cucumber/json/core/castto/CastToUtil.java - About 1 hr to fix

                Method checkSplit has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private PathElement checkSplit(final String path, final String split)
            throws InvalidPathException {

        LOGGER.debug("path='{}' split='{}'", path, split);
                Severity: Minor
                Found in json/core/src/main/java/com/github/nhojpatrick/cucumber/json/core/validation/impl/PathValidatorImpl.java - About 1 hr to fix

                  Method perform has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      @Override
    public Map<String, Object> perform(final PathElement pathElement,
                                       final Map<String, Object> inputRaw,
                                       final String currentPath)
            throws IllegalKeyException,
                  Severity: Minor
                  Found in json-transformations/set/src/main/java/com/github/nhojpatrick/cucumber/json/transformations/set/SetTransformation.java - About 1 hr to fix

                    Method parsePath has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        @Override
    public List<PathElement> parsePath(final String path)
            throws InvalidPathException {

        LOGGER.debug("parsePath.entry path='{}'", path);
                    Severity: Minor
                    Found in json/core/src/main/java/com/github/nhojpatrick/cucumber/json/core/validation/impl/PathValidatorImpl.java - About 1 hr to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public void convertMapToJson(final RunState runState,
                                 final String runStateJsonMapKey,
                                 final String runStateJsonStringKey)
            throws IllegalKeyException,
            IllegalTypeClassException,
                      Severity: Major
                      Found in json/map/src/main/java/com/github/nhojpatrick/cucumber/json/map/ConvertJsonMapUtil.java and 1 other location - About 1 hr to fix
                      json/map/src/main/java/com/github/nhojpatrick/cucumber/json/map/ConvertJsonMapUtil.java on lines 65..85

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 86.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public void convertObjectToMap(final RunState runState,
                                   final String runStateObjectKey,
                                   final String runStateJsonMapKey)
            throws IllegalKeyException,
            IllegalTypeClassException,
                      Severity: Major
                      Found in json/map/src/main/java/com/github/nhojpatrick/cucumber/json/map/ConvertJsonMapUtil.java and 1 other location - About 1 hr to fix
                      json/map/src/main/java/com/github/nhojpatrick/cucumber/json/map/ConvertJsonMapUtil.java on lines 43..63

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 86.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Method verify has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          @Override
    public void verify(final RunState runState)
            throws NullRunStateException {

        if (isNull(runState)) {
                      Severity: Minor
                      Found in state/src/main/java/com/github/nhojpatrick/cucumber/state/validation/impl/RunStateValidatorImpl.java - About 1 hr to fix

                        Similar blocks of code found in 5 locations. Consider refactoring.
                        Open

                            @Given("TestingInternalSteps I convert object using RunStateKey {string}, to json map using RunStateKey {string} produces the AssertionError {string}")
    public void convertObjectToMap_AssertionError(final String runStateObjectKey,
                                                  final String runStateJsonMapKey,
                                                  final String expectedExceptionMessageRaw) {
                        Severity: Major
                        Found in testing-internal/glue/src/main/java/com/github/nhojpatrick/cucumber/testing/internal/steps/json/map/ConvertObjectToMap_TestingInternalSteps.java and 4 other locations - About 1 hr to fix
                        testing-internal/glue/src/main/java/com/github/nhojpatrick/cucumber/testing/internal/steps/json/map/ConvertMapToJson_TestingInternalSteps.java on lines 37..52
                        testing-internal/glue/src/main/java/com/github/nhojpatrick/cucumber/testing/internal/steps/json/map/ConvertMapToJson_TestingInternalSteps.java on lines 64..79
                        testing-internal/glue/src/main/java/com/github/nhojpatrick/cucumber/testing/internal/steps/json/map/ConvertObjectToMap_TestingInternalSteps.java on lines 65..81
                        testing-internal/glue/src/main/java/com/github/nhojpatrick/cucumber/testing/internal/steps/json/map/ConvertObjectToMap_TestingInternalSteps.java on lines 93..109

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 82.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 5 locations. Consider refactoring.
                        Open

                            @Given("TestingInternalSteps I convert json map using RunStateKey {string}, to json string using RunStateKey {string} produces the AssertionError {string}")
    public void convertMapToJson_AssertionError(final String runStateJsonMapKey,
                                                final String runStateJsonStringKey,
                                                final String expectedExceptionMessageRaw) {
                        Severity: Major
                        Found in testing-internal/glue/src/main/java/com/github/nhojpatrick/cucumber/testing/internal/steps/json/map/ConvertMapToJson_TestingInternalSteps.java and 4 other locations - About 1 hr to fix
                        testing-internal/glue/src/main/java/com/github/nhojpatrick/cucumber/testing/internal/steps/json/map/ConvertMapToJson_TestingInternalSteps.java on lines 64..79
                        testing-internal/glue/src/main/java/com/github/nhojpatrick/cucumber/testing/internal/steps/json/map/ConvertObjectToMap_TestingInternalSteps.java on lines 37..53
                        testing-internal/glue/src/main/java/com/github/nhojpatrick/cucumber/testing/internal/steps/json/map/ConvertObjectToMap_TestingInternalSteps.java on lines 65..81
                        testing-internal/glue/src/main/java/com/github/nhojpatrick/cucumber/testing/internal/steps/json/map/ConvertObjectToMap_TestingInternalSteps.java on lines 93..109

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 82.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Severity
                        Category
                        Status
                        Source
                        Language