Sign upLogin

nicholalexander/basket

View on GitHub
Star
lib/basket/backend_adapter/memory_backend.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Basket::BackendAdapter::MemoryBackend#push calls '@data[queue]' 2 times
Open

        @data[queue] = [] if @data[queue].nil?
        @data[queue] <<= data
Severity: Minor
Found in lib/basket/backend_adapter/memory_backend.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Basket::BackendAdapter::MemoryBackend#length calls '@data[queue]' 2 times
Open

        return 0 if @data[queue].nil?

        @data[queue].length
Severity: Minor
Found in lib/basket/backend_adapter/memory_backend.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Basket::BackendAdapter::MemoryBackend#remove calls '@data[queue]' 2 times
Open

        index_of_element_to_delete = @data[queue].index { |element| element.id == id }
        @data[queue].delete_at(index_of_element_to_delete)
Severity: Minor
Found in lib/basket/backend_adapter/memory_backend.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Basket::BackendAdapter::MemoryBackend has no descriptive comment
Open

    class MemoryBackend < Basket::BackendAdapter
Severity: Minor
Found in lib/basket/backend_adapter/memory_backend.rb by reek

Classes and modules are the units of reuse and release. It is therefore considered good practice to annotate every class and module with a brief comment outlining its responsibilities.

Example

Given

class Dummy
  # Do things...
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [1]:Dummy has no descriptive comment (IrresponsibleModule)

Fixing this is simple - just an explaining comment:

# The Dummy class is responsible for ...
class Dummy
  # Do things...
end

Basket::BackendAdapter::MemoryBackend#length performs a nil-check
Open

        return 0 if @data[queue].nil?
Severity: Minor
Found in lib/basket/backend_adapter/memory_backend.rb by reek

A NilCheck is a type check. Failures of NilCheck violate the "tell, don't ask" principle.

Additionally, type checks often mask bigger problems in your source code like not using OOP and / or polymorphism when you should.

Example

Given

class Klass
  def nil_checker(argument)
    if argument.nil?
      puts "argument isn't nil!"
    end
  end
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [3]:Klass#nil_checker performs a nil-check. (NilCheck)

Basket::BackendAdapter::MemoryBackend#push performs a nil-check
Open

        @data[queue] = [] if @data[queue].nil?
Severity: Minor
Found in lib/basket/backend_adapter/memory_backend.rb by reek

A NilCheck is a type check. Failures of NilCheck violate the "tell, don't ask" principle.

Additionally, type checks often mask bigger problems in your source code like not using OOP and / or polymorphism when you should.

Example

Given

class Klass
  def nil_checker(argument)
    if argument.nil?
      puts "argument isn't nil!"
    end
  end
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [3]:Klass#nil_checker performs a nil-check. (NilCheck)

There are no issues that match your filters.

Category
Status